[Freeswitch-users] conference param video-floor-only

[Seven Du]

Hi, 

What is video-floor-only trying to do in conference? I assume it tries to freeze the floor holder ( and his video) as long as he has video, but in my testing it's not the case, I set the param in the default profile and it seems doesn't make any difference. I tried the following change it looks more clear to me and seems works as what I expected.


-                               if ((!floor_holder || (imember->score_iir > SCORE_IIR_SPEAKING_MAX && (floor_holder->score_iir < SCORE_IIR_SPEAKING_MIN))) &&
-                                       (!switch_test_flag(conference, CFLAG_VID_FLOOR) || switch_channel_test_flag(channel, CF_VIDEO))) {
-                                       floor_holder = imember;
+                               if (switch_channel_test_flag(channel, CF_VIDEO)) {
+                                       if (!floor_holder) {
+                                               floor_holder = imember;
+                                       } else if ((imember->score_iir > SCORE_IIR_SPEAKING_MAX) && (floor_holder->score_iir < SCORE_IIR_SPEAKING_MIN) &&
+                                       (!switch_test_flag(conference, CFLAG_VID_FLOOR))) {
+                                               floor_holder = imember;
+                                       }
                                }




Another thing I found is that in the normal case(without floor-only set), the video changes according to the volume of the speaker fine, but if the floor press 0 to be muted, there's no chance of other members can get the floor, is there a problem?


Thanks.



-- 
About: http://about.me/dujinfang
Blog: http://www.dujinfang.com
Proj:  http://www.freeswitch.org.cn

Sent with Sparrow (http://www.sparrowmailapp.com)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.freeswitch.org/pipermail/freeswitch-users/attachments/20120704/d7e98705/attachment.html