[Freeswitch-users] fail to build git version of freeswitch

Josh mojo1736 at privatedemail.net
Wed Feb 29 18:44:51 MSK 2012


> Josh,
> Please test the patch at 
>
> http://jira.freeswitch.org/browse/FS-3711
>
> testpatch.txt
>
> which is provided by Alexey.
>   
I don't want to act like a smug idiot, but I like my version of the 
patch better for (at least) 2 reasons:

1. The original patch modifications (hack_out_ogg.diff) made by my patch 
no longer use "relative" paths (i.e. "../../") and thus comply with any 
version of the patch used.

2. My modifications made to the appropriate mod_shout Makefile are much 
better, because they use SHOUT_BUILDDIR, which is already defined in 
that Makefile, and do not rely on some hard-coded path ("../../../../" 
for example). In other words, I think:

patch -d $(SHOUT_BUILDDIR) -p1 < hack_out_ogg.diff (which is what my 
patch proposes) is much better than:
patch -p 6 -d ../../../../libs/libshout-2.2.2 < hack_out_ogg.diff (which 
is what Alexsey have proposed)





Join us at ClueCon 2011 Aug 9-11, 2011
More information about the FreeSWITCH-users mailing list