<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[Freeswitch-trunk][16754] </title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<div id="header">FreeSWITCH Subversion</div>
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://fisheye.freeswitch.org/changelog/FreeSWITCH?cs=16754">16754</a></dd>
<dt>Author</dt> <dd>sathieu</dd>
<dt>Date</dt> <dd>2010-02-24 05:58:43 -0600 (Wed, 24 Feb 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre> Skinny: Milestone 1 : device level (multiple replies)
- A request can call several replies</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#freeswitchtrunksrcmodendpointsmod_skinnymod_skinnyc">freeswitch/trunk/src/mod/endpoints/mod_skinny/mod_skinny.c</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="freeswitchtrunksrcmodendpointsmod_skinnymod_skinnyc"></a>
<div class="modfile"><h4>Modified: freeswitch/trunk/src/mod/endpoints/mod_skinny/mod_skinny.c (16753 => 16754)</h4>
<pre class="diff"><span>
<span class="info">--- freeswitch/trunk/src/mod/endpoints/mod_skinny/mod_skinny.c 2010-02-24 11:58:36 UTC (rev 16753)
+++ freeswitch/trunk/src/mod/endpoints/mod_skinny/mod_skinny.c 2010-02-24 11:58:43 UTC (rev 16754)
</span><span class="lines">@@ -767,14 +767,13 @@
</span><span class="cx"> return SWITCH_STATUS_SUCCESS;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static switch_status_t skinny_parse_request(listener_t *listener, skinny_message_t *request, skinny_message_t **rep)
</del><ins>+static switch_status_t skinny_handle_request(listener_t *listener, skinny_message_t *request)
</ins><span class="cx"> {
</span><del>- skinny_message_t *reply, *message;
</del><ins>+ skinny_message_t *message;
</ins><span class="cx"> skinny_device_t *device;
</span><span class="cx"> uint32_t i = 0;
</span><span class="cx"> uint32_t n = 0;
</span><span class="cx"> size_t string_len, string_pos, pos;
</span><del>- reply = NULL;
</del><span class="cx"> switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_INFO,
</span><span class="cx"> "Received message of type %d.\n", request->type);
</span><span class="cx"> if(!listener->device && request->type != REGISTER_MESSAGE) {
</span><span class="lines">@@ -804,12 +803,13 @@
</span><span class="cx"> listener->device = device;
</span><span class="cx">
</span><span class="cx"> /* Reply with RegisterAckMessage */
</span><del>- reply = switch_core_alloc(listener->pool, 12+sizeof(reply->data.reg_ack));
- reply->type = REGISTER_ACK_MESSAGE;
- reply->length = 4 + sizeof(reply->data.reg_ack);
- reply->data.reg_ack.keepAlive = globals.keep_alive;
- memcpy(reply->data.reg_ack.dateFormat, globals.date_format, 6);
- reply->data.reg_ack.secondaryKeepAlive = globals.keep_alive;
</del><ins>+ message = switch_core_alloc(listener->pool, 12+sizeof(message->data.reg_ack));
+ message->type = REGISTER_ACK_MESSAGE;
+ message->length = 4 + sizeof(message->data.reg_ack);
+ message->data.reg_ack.keepAlive = globals.keep_alive;
+ memcpy(message->data.reg_ack.dateFormat, globals.date_format, 6);
+ message->data.reg_ack.secondaryKeepAlive = globals.keep_alive;
+ skinny_send_reply(listener, message);
</ins><span class="cx">
</span><span class="cx"> /* Send CapabilitiesReqMessage */
</span><span class="cx"> message = switch_core_alloc(listener->pool, 12);
</span><span class="lines">@@ -853,17 +853,17 @@
</span><span class="cx"> device->port = request->data.as_uint16;
</span><span class="cx"> break;
</span><span class="cx"> case KEEP_ALIVE_MESSAGE:
</span><del>- reply = switch_core_alloc(listener->pool, 12);
- reply->type = KEEP_ALIVE_ACK_MESSAGE;
- reply->length = 4;
</del><ins>+ message = switch_core_alloc(listener->pool, 12);
+ message->type = KEEP_ALIVE_ACK_MESSAGE;
+ message->length = 4;
</ins><span class="cx"> keepalive_listener(listener, NULL);
</span><ins>+ skinny_send_reply(listener, message);
</ins><span class="cx"> break;
</span><span class="cx"> /* TODO */
</span><span class="cx"> default:
</span><span class="cx"> switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR,
</span><span class="cx"> "Unknown request type: %d.\n", request->type);
</span><span class="cx"> }
</span><del>- *rep = reply;
</del><span class="cx"> return SWITCH_STATUS_SUCCESS;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1066,17 +1066,12 @@
</span><span class="cx"> continue;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (skinny_parse_request(listener, request, &reply) != SWITCH_STATUS_SUCCESS) {
</del><ins>+ if (skinny_handle_request(listener, request) != SWITCH_STATUS_SUCCESS) {
</ins><span class="cx"> switch_clear_flag_locked(listener, LFLAG_RUNNING);
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> skinny_free_message(request);
</span><del>-
- if (reply != NULL) {
- skinny_send_reply(listener, reply);
- }
- skinny_free_message(reply);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> done:
</span></span></pre>
</div>
</div>
<div id="footer">See you at ClueCon</div>
</body>
</html>