<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[Freeswitch-trunk][16756] </title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<div id="header">FreeSWITCH Subversion</div>
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://fisheye.freeswitch.org/changelog/FreeSWITCH?cs=16756">16756</a></dd>
<dt>Author</dt> <dd>sathieu</dd>
<dt>Date</dt> <dd>2010-02-24 05:59:02 -0600 (Wed, 24 Feb 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Skinny: Milestone 1 : device level (codec list)
- update codec list</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#freeswitchtrunksrcmodendpointsmod_skinnymod_skinnyc">freeswitch/trunk/src/mod/endpoints/mod_skinny/mod_skinny.c</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="freeswitchtrunksrcmodendpointsmod_skinnymod_skinnyc"></a>
<div class="modfile"><h4>Modified: freeswitch/trunk/src/mod/endpoints/mod_skinny/mod_skinny.c (16755 => 16756)</h4>
<pre class="diff"><span>
<span class="info">--- freeswitch/trunk/src/mod/endpoints/mod_skinny/mod_skinny.c        2010-02-24 11:58:54 UTC (rev 16755)
+++ freeswitch/trunk/src/mod/endpoints/mod_skinny/mod_skinny.c        2010-02-24 11:59:02 UTC (rev 16756)
</span><span class="lines">@@ -62,6 +62,7 @@
</span><span class="cx"> static struct {
</span><span class="cx">         /* prefs */
</span><span class="cx">         int debug;
</span><ins>+        char *domain;
</ins><span class="cx">         char *ip;
</span><span class="cx">         unsigned int port;
</span><span class="cx">         char *dialplan;
</span><span class="lines">@@ -98,6 +99,7 @@
</span><span class="cx"> typedef struct private_object private_t;
</span><span class="cx">
</span><span class="cx">
</span><ins>+SWITCH_DECLARE_GLOBAL_STRING_FUNC(set_global_domain, globals.domain);
</ins><span class="cx"> SWITCH_DECLARE_GLOBAL_STRING_FUNC(set_global_ip, globals.ip);
</span><span class="cx"> SWITCH_DECLARE_GLOBAL_STRING_FUNC(set_global_dialplan, globals.dialplan);
</span><span class="cx"> SWITCH_DECLARE_GLOBAL_STRING_FUNC(set_global_codec_string, globals.codec_string);
</span><span class="lines">@@ -124,6 +126,12 @@
</span><span class="cx"> /* IpPortMessage */
</span><span class="cx"> #define PORT_MESSAGE 0x0002
</span><span class="cx">
</span><ins>+/* LineStatReqMessage */
+#define LINE_STAT_REQ_MESSAGE 0x000B
+struct line_stat_req_message {
+        uint32_t number;
+};
+
</ins><span class="cx"> /* CapabilitiesResMessage */
</span><span class="cx"> struct station_capabilities {
</span><span class="cx">         uint32_t codec;
</span><span class="lines">@@ -147,16 +155,28 @@
</span><span class="cx">         char reserved2[4];
</span><span class="cx"> };
</span><span class="cx">
</span><ins>+/* LineStatMessage */
+#define LINE_STAT_RES_MESSAGE 0x0092
+struct line_stat_res_message {
+        uint32_t number;
+        char name[24];
+        char shortname[40];
+        char displayname[44];
+};
+
</ins><span class="cx"> /* CapabilitiesReqMessage */
</span><span class="cx"> #define CAPABILITIES_REQ_MESSAGE 0x009B
</span><span class="cx">
</span><ins>+/* RegisterRejectMessage */
+#define REGISTER_REJ_MESSAGE 0x009D
+struct register_rej_message {
+        char error[33];
+};
+
</ins><span class="cx"> /* KeepAliveAckMessage */
</span><span class="cx"> #define KEEP_ALIVE_ACK_MESSAGE 0x0100
</span><span class="cx">
</span><del>-/*****************************************************************************/
-/* SKINNY TYPES */
-/*****************************************************************************/
-
</del><ins>+/* Message */
</ins><span class="cx"> #define SKINNY_MESSAGE_FIELD_SIZE 4 /* 4-bytes field */
</span><span class="cx"> #define SKINNY_MESSAGE_HEADERSIZE 12 /* three 4-bytes fields */
</span><span class="cx"> #define SKINNY_MESSAGE_MAXSIZE 1000
</span><span class="lines">@@ -164,7 +184,10 @@
</span><span class="cx"> union skinny_data {
</span><span class="cx">         struct register_message reg;
</span><span class="cx">         struct register_ack_message reg_ack;
</span><ins>+        struct line_stat_req_message line_req;
</ins><span class="cx">         struct capabilities_res_message cap_res;
</span><ins>+        struct line_stat_res_message line_res;
+        struct register_rej_message reg_rej;
</ins><span class="cx">         
</span><span class="cx">         uint16_t as_uint16;
</span><span class="cx">         char as_char;
</span><span class="lines">@@ -179,7 +202,27 @@
</span><span class="cx"> };
</span><span class="cx"> typedef struct skinny_message skinny_message_t;
</span><span class="cx">
</span><ins>+/*****************************************************************************/
+/* SKINNY TYPES */
+/*****************************************************************************/
</ins><span class="cx">
</span><ins>+#define SKINNY_MAX_LINES 10
+struct skinny_line {
+        struct skinny_device_t *device;
+        char name[24];
+        char shortname[40];
+        char displayname[44];
+};
+typedef struct skinny_line skinny_line_t;
+
+#define SKINNY_MAX_SPEEDDIALS 20
+struct skinny_speeddial {
+        struct skinny_device_t *device;
+        char number[24];
+        char displayname[40];
+};
+typedef struct skinny_speeddial skinny_speeddial_t;
+
</ins><span class="cx"> struct skinny_device {
</span><span class="cx">         char deviceName[16];
</span><span class="cx">         uint32_t userId;
</span><span class="lines">@@ -193,19 +236,51 @@
</span><span class="cx">         char *codec_string;
</span><span class="cx">         char *codec_order[SWITCH_MAX_CODECS];
</span><span class="cx">         int codec_order_last;
</span><ins>+
+        skinny_line_t line[SKINNY_MAX_LINES];
+        int line_last;
+        skinny_speeddial_t speeddial[SKINNY_MAX_SPEEDDIALS];
+        int speeddial_last;
</ins><span class="cx"> };
</span><span class="cx"> typedef struct skinny_device skinny_device_t;
</span><span class="cx">
</span><span class="cx"> typedef switch_status_t (*skinny_command_t) (char **argv, int argc, switch_stream_handle_t *stream);
</span><span class="cx">
</span><span class="cx"> enum skinny_codecs {
</span><del>-        SKINNY_CODEC_ALAW = 2,
-        SKINNY_CODEC_ULAW = 4,
</del><ins>+        SKINNY_CODEC_ALAW_64K = 2,
+        SKINNY_CODEC_ALAW_56K = 3,
+        SKINNY_CODEC_ULAW_64K = 4,
+        SKINNY_CODEC_ULAW_56K = 5,
+        SKINNY_CODEC_G722_64K = 6,
+        SKINNY_CODEC_G722_56K = 7,
+        SKINNY_CODEC_G722_48K = 8,
</ins><span class="cx">         SKINNY_CODEC_G723_1 = 9,
</span><ins>+        SKINNY_CODEC_G728 = 10,
+        SKINNY_CODEC_G729 = 11,
</ins><span class="cx">         SKINNY_CODEC_G729A = 12,
</span><del>-        SKINNY_CODEC_G726_32 = 82,
</del><ins>+        SKINNY_CODEC_IS11172 = 13,
+        SKINNY_CODEC_IS13818 = 14,
+        SKINNY_CODEC_G729B = 15,
+        SKINNY_CODEC_G729AB = 16,
+        SKINNY_CODEC_GSM_FULL = 18,
+        SKINNY_CODEC_GSM_HALF = 19,
+        SKINNY_CODEC_GSM_EFULL = 20,
+        SKINNY_CODEC_WIDEBAND_256K = 25,
+        SKINNY_CODEC_DATA_64K = 32,
+        SKINNY_CODEC_DATA_56K = 33,
+        SKINNY_CODEC_GSM = 80,
+        SKINNY_CODEC_ACTIVEVOICE = 81,
+        SKINNY_CODEC_G726_32K = 82,
+        SKINNY_CODEC_G726_24K = 83,
+        SKINNY_CODEC_G726_16K = 84,
+        SKINNY_CODEC_G729B_BIS = 85,
+        SKINNY_CODEC_G729B_LOW = 86,
</ins><span class="cx">         SKINNY_CODEC_H261 = 100,
</span><del>-        SKINNY_CODEC_H263 = 101
</del><ins>+        SKINNY_CODEC_H263 = 101,
+        SKINNY_CODEC_VIDEO = 102,
+        SKINNY_CODEC_T120 = 105,
+        SKINNY_CODEC_H224 = 106,
+        SKINNY_CODEC_RFC2833_DYNPAYLOAD = 257
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> /*****************************************************************************/
</span><span class="lines">@@ -670,22 +745,64 @@
</span><span class="cx"> static char* skinny_codec2string(enum skinny_codecs skinnycodec)
</span><span class="cx"> {
</span><span class="cx">         switch (skinnycodec) {
</span><del>-        case SKINNY_CODEC_ALAW:
-                return "ALAW";
-        case SKINNY_CODEC_ULAW:
-                return "ULAW";
-        case SKINNY_CODEC_G723_1:
-                return "G723_1";
-        case SKINNY_CODEC_G729A:
-                return "G729A";
-        case SKINNY_CODEC_G726_32:
-                return "G726_AAL2";
-        case SKINNY_CODEC_H261:
-                return "H261";
-        case SKINNY_CODEC_H263:
-                return "H263";
-        default:
-                return "";
</del><ins>+                case SKINNY_CODEC_ALAW_64K:
+                case SKINNY_CODEC_ALAW_56K:
+                        return "ALAW";
+                case SKINNY_CODEC_ULAW_64K:
+                case SKINNY_CODEC_ULAW_56K:
+                        return "ULAW";
+                case SKINNY_CODEC_G722_64K:
+                case SKINNY_CODEC_G722_56K:
+                case SKINNY_CODEC_G722_48K:
+                        return "G722";
+                case SKINNY_CODEC_G723_1:
+                        return "G723";
+                case SKINNY_CODEC_G728:
+                        return "G728";
+                case SKINNY_CODEC_G729:
+                case SKINNY_CODEC_G729A:
+                        return "G729";
+                case SKINNY_CODEC_IS11172:
+                        return "IS11172";
+                case SKINNY_CODEC_IS13818:
+                        return "IS13818";
+                case SKINNY_CODEC_G729B:
+                case SKINNY_CODEC_G729AB:
+                        return "G729";
+                case SKINNY_CODEC_GSM_FULL:
+                case SKINNY_CODEC_GSM_HALF:
+                case SKINNY_CODEC_GSM_EFULL:
+                        return "GSM";
+                case SKINNY_CODEC_WIDEBAND_256K:
+                        return "WIDEBAND";
+                case SKINNY_CODEC_DATA_64K:
+                case SKINNY_CODEC_DATA_56K:
+                        return "DATA";
+                case SKINNY_CODEC_GSM:
+                        return "GSM";
+                case SKINNY_CODEC_ACTIVEVOICE:
+                        return "ACTIVEVOICE";
+                case SKINNY_CODEC_G726_32K:
+                case SKINNY_CODEC_G726_24K:
+                case SKINNY_CODEC_G726_16K:
+                        return "G726";
+                case SKINNY_CODEC_G729B_BIS:
+                case SKINNY_CODEC_G729B_LOW:
+                        return "G729";
+                case SKINNY_CODEC_H261:
+                        return "H261";
+                case SKINNY_CODEC_H263:
+                        return "H263";
+                case SKINNY_CODEC_VIDEO:
+                        return "VIDEO";
+                case SKINNY_CODEC_T120:
+                        return "T120";
+                case SKINNY_CODEC_H224:
+                        return "H224";
+                case SKINNY_CODEC_RFC2833_DYNPAYLOAD:
+                        return "RFC2833_DYNPAYLOAD";
+                default:
+                        return "";
</ins><span class="cx">         }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -735,7 +852,7 @@
</span><span class="cx">                                 ptr += mlen;
</span><span class="cx">                                 memcpy(request, mbuf, bytes);
</span><span class="cx">                                 switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_INFO,
</span><del>-                                        "Got request: length=%d,reserved=%d,type=%d\n",
</del><ins>+                                        "Got request: length=%d,reserved=%x,type=%x\n",
</ins><span class="cx">                                         request->length,request->reserved,request->type);
</span><span class="cx">                                 if(request->length < SKINNY_MESSAGE_FIELD_SIZE) {
</span><span class="cx">                                         switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR,
</span><span class="lines">@@ -752,7 +869,7 @@
</span><span class="cx">                                 if(bytes >= request->length + 2*SKINNY_MESSAGE_FIELD_SIZE) {
</span><span class="cx">                                         /* Message body */
</span><span class="cx">                                         switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_INFO,
</span><del>-                                                "Got complete request: length=%d,reserved=%d,type=%d,data=%d\n",
</del><ins>+                                                "Got complete request: length=%d,reserved=%x,type=%x,data=%d\n",
</ins><span class="cx">                                                 request->length,request->reserved,request->type,request->data.as_char);
</span><span class="cx">                                         *req = request;
</span><span class="cx">                                         return SWITCH_STATUS_SUCCESS;
</span><span class="lines">@@ -773,6 +890,7 @@
</span><span class="cx">         switch_event_t *event = NULL;
</span><span class="cx">         skinny_device_t *device;
</span><span class="cx">         switch_event_create_subclass(&event, event_id, subclass_name);
</span><ins>+        switch_assert(event);
</ins><span class="cx">         if(listener->device) {
</span><span class="cx">                 device = listener->device;
</span><span class="cx">                 switch_event_add_header_string(event, SWITCH_STACK_BOTTOM, "Skinny-Device-Name", switch_str_nil(device->deviceName));
</span><span class="lines">@@ -788,17 +906,108 @@
</span><span class="cx">         return SWITCH_STATUS_SUCCESS;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+static switch_status_t skinny_handle_register(listener_t *listener, skinny_message_t *request)
+{
+        switch_status_t status = SWITCH_STATUS_FALSE;
+        skinny_message_t *message;
+        skinny_device_t *device;
+        switch_event_t *event = NULL;
+        switch_event_t *params = NULL;
+        switch_xml_t xml = NULL, domain, group, users, user;
+
+        if(listener->device) {
+                switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR,
+                        "A device is already registred on this listener.\n");
+                message = switch_core_alloc(listener->pool, 12+sizeof(message->data.reg_rej));
+                message->type = REGISTER_REJ_MESSAGE;
+                message->length = 4 + sizeof(message->data.reg_rej);
+                strcpy(message->data.reg_rej.error, "A device is already registred on this listener");
+                skinny_send_reply(listener, message);
+                return SWITCH_STATUS_FALSE;
+        }
+        /* Initialize device */
+        device = switch_core_alloc(listener->pool, sizeof(skinny_device_t));
+        memcpy(device->deviceName, request->data.reg.deviceName, 16);
+        device->userId = request->data.reg.userId;
+        device->instance = request->data.reg.instance;
+        device->ip = request->data.reg.ip;
+        device->deviceType = request->data.reg.deviceType;
+        device->maxStreams = request->data.reg.maxStreams;
+        device->codec_string = realloc(device->codec_string, 1);
+        device->codec_string[0] = '\0';
+
+        /* Check directory */
+        skinny_device_event(listener, &params, SWITCH_EVENT_REQUEST_PARAMS, SWITCH_EVENT_SUBCLASS_ANY);
+        switch_event_add_header_string(params, SWITCH_STACK_BOTTOM, "action", "skinny-auth");
+
+        if (switch_xml_locate_group(device->deviceName, globals.domain, &xml, &domain, &group, params) != SWITCH_STATUS_SUCCESS) {
+                switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_WARNING, "Can't find device [%s@%s]\n"
+                                         "You must define a domain called '%s' in your directory and add a group with the name=\"%s\" attribute.\n"
+                                         , device->deviceName, globals.domain, globals.domain, device->deviceName);
+                message = switch_core_alloc(listener->pool, 12+sizeof(message->data.reg_rej));
+                message->type = REGISTER_REJ_MESSAGE;
+                message->length = 4 + sizeof(message->data.reg_rej);
+                strcpy(message->data.reg_rej.error, "Device not found");
+                skinny_send_reply(listener, message);
+                return SWITCH_STATUS_FALSE;
+                goto end;
+        }
+        users = switch_xml_child(group, "users");
+        device->line_last = 0;
+        if(users) {
+                for (user = switch_xml_child(users, "user"); user; user = user->next) {
+                        const char *id = switch_xml_attr_soft(user, "id");
+                        const char *type = switch_xml_attr_soft(user, "type");
+                        //TODO device->line[device->line_last].device = *device;
+                        strcpy(device->line[device->line_last].name, id);
+                        strcpy(device->line[device->line_last].shortname, id);
+                        strcpy(device->line[device->line_last].displayname, id);
+                        device->line_last++;
+                }
+        }
+
+        listener->device = device;
+        status = SWITCH_STATUS_SUCCESS;
+
+        /* Reply with RegisterAckMessage */
+        message = switch_core_alloc(listener->pool, 12+sizeof(message->data.reg_ack));
+        message->type = REGISTER_ACK_MESSAGE;
+        message->length = 4 + sizeof(message->data.reg_ack);
+        message->data.reg_ack.keepAlive = globals.keep_alive;
+        memcpy(message->data.reg_ack.dateFormat, globals.date_format, 6);
+        message->data.reg_ack.secondaryKeepAlive = globals.keep_alive;
+        skinny_send_reply(listener, message);
+
+        /* Send CapabilitiesReqMessage */
+        message = switch_core_alloc(listener->pool, 12);
+        message->type = CAPABILITIES_REQ_MESSAGE;
+        message->length = 4;
+        skinny_send_reply(listener, message);
+
+        /* skinny::register event */
+        skinny_device_event(listener, &event, SWITCH_EVENT_CUSTOM, SKINNY_EVENT_REGISTER);
+        switch_event_fire(&event);
+        
+        keepalive_listener(listener, NULL);
+
+end:
+        if(params) {
+                switch_event_destroy(&params);
+        }
+        
+        return status;
+}
+
</ins><span class="cx"> static switch_status_t skinny_handle_request(listener_t *listener, skinny_message_t *request)
</span><span class="cx"> {
</span><del>- skinny_message_t *message;
- skinny_device_t *device;
</del><ins>+        skinny_message_t *message;
+        skinny_device_t *device;
</ins><span class="cx">         uint32_t i = 0;
</span><span class="cx">         uint32_t n = 0;
</span><span class="cx">         size_t string_len, string_pos, pos;
</span><del>-        switch_event_t *event = NULL;
</del><span class="cx">
</span><span class="cx">         switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_INFO,
</span><del>-                "Received message of type %d.\n", request->type);
</del><ins>+                "Received message (type=%x,length=%d).\n", request->type, request->length);
</ins><span class="cx">         if(!listener->device && request->type != REGISTER_MESSAGE) {
</span><span class="cx">                 switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR,
</span><span class="cx">                         "Device should send a register message first.\n");
</span><span class="lines">@@ -807,47 +1016,7 @@
</span><span class="cx">         device = listener->device;
</span><span class="cx">         switch(request->type) {
</span><span class="cx">                 case REGISTER_MESSAGE:
</span><del>-                        if(listener->device) {
-                                switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR,
-                                        "A device is already registred on this listener.\n");
-                                return SWITCH_STATUS_FALSE;
-                        }
-                        /* Initialize device */
-                        device = switch_core_alloc(listener->pool, sizeof(skinny_device_t));
-                        memcpy(device->deviceName, request->data.reg.deviceName, 16);
-                        device->userId = request->data.reg.userId;
-                        device->instance = request->data.reg.instance;
-                        device->ip = request->data.reg.ip;
-                        device->deviceType = request->data.reg.deviceType;
-                        device->maxStreams = request->data.reg.maxStreams;
-                        device->codec_string = realloc(device->codec_string, 1);
-                        device->codec_string[0] = '\0';
-
-                        /* TODO : check directory */
-
-                        listener->device = device;
-
-                        /* Reply with RegisterAckMessage */
-                        message = switch_core_alloc(listener->pool, 12+sizeof(message->data.reg_ack));
-                        message->type = REGISTER_ACK_MESSAGE;
-                        message->length = 4 + sizeof(message->data.reg_ack);
-                        message->data.reg_ack.keepAlive = globals.keep_alive;
-                        memcpy(message->data.reg_ack.dateFormat, globals.date_format, 6);
-                        message->data.reg_ack.secondaryKeepAlive = globals.keep_alive;
-                        skinny_send_reply(listener, message);
-
-                        /* Send CapabilitiesReqMessage */
-                        message = switch_core_alloc(listener->pool, 12);
-                        message->type = CAPABILITIES_REQ_MESSAGE;
-                        message->length = 4;
-                        skinny_send_reply(listener, message);
-
-                        /* skinny::register event */
-                        skinny_device_event(listener, &event, SWITCH_EVENT_CUSTOM, SKINNY_EVENT_REGISTER);
-                        switch_event_fire(&event);
-                        
-                        keepalive_listener(listener, NULL);
-                        break;
</del><ins>+                        return skinny_handle_register(listener, request);
</ins><span class="cx">                 case CAPABILITIES_RES_MESSAGE:
</span><span class="cx">                         n = request->data.cap_res.count;
</span><span class="cx">                         if (n > SWITCH_MAX_CODECS) {
</span><span class="lines">@@ -880,6 +1049,23 @@
</span><span class="cx">                 case PORT_MESSAGE:
</span><span class="cx">                         device->port = request->data.as_uint16;
</span><span class="cx">                         break;
</span><ins>+                case LINE_STAT_REQ_MESSAGE:
+                        message = switch_core_alloc(listener->pool, 12+sizeof(message->data.line_res));
+                        message->type = LINE_STAT_RES_MESSAGE;
+                        message->length = 4 + sizeof(message->data.line_res);
+                        i = request->data.line_req.number;
+                        if(i > 0 && i <= device->line_last) {
+                                message->data.line_res.number = i;
+                                strcpy(message->data.line_res.name, device->line[i-1].name);
+                                strcpy(message->data.line_res.shortname, device->line[i-1].shortname);
+                                strcpy(message->data.line_res.displayname, device->line[i-1].displayname);
+                        } else {
+                                strcpy(message->data.line_res.name, "");
+                                strcpy(message->data.line_res.shortname, "");
+                                strcpy(message->data.line_res.displayname, "");
+                        }
+                        skinny_send_reply(listener, message);
+                        break;
</ins><span class="cx">                 case KEEP_ALIVE_MESSAGE:
</span><span class="cx">                         message = switch_core_alloc(listener->pool, 12);
</span><span class="cx">                         message->type = KEEP_ALIVE_ACK_MESSAGE;
</span><span class="lines">@@ -902,7 +1088,8 @@
</span><span class="cx">         switch_assert(reply != NULL);
</span><span class="cx">         len = reply->length+8;
</span><span class="cx">         ptr = (char *) reply;
</span><del>-        switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_INFO, "Sending reply (length=%d).\n", len);
</del><ins>+        switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_INFO, "Sending reply (type=%x,length=%d).\n",
+                reply->type, reply->length);
</ins><span class="cx">         switch_socket_send(listener->sock, ptr, &len);
</span><span class="cx">         return SWITCH_STATUS_SUCCESS;
</span><span class="cx"> }
</span><span class="lines">@@ -1281,6 +1468,8 @@
</span><span class="cx">
</span><span class="cx">                         if (!strcmp(var, "debug")) {
</span><span class="cx">                                 globals.debug = atoi(val);
</span><ins>+                        } else if (!strcmp(var, "domain")) {
+                                set_global_domain(val);
</ins><span class="cx">                         } else if (!strcmp(var, "ip")) {
</span><span class="cx">                                 set_global_ip(val);
</span><span class="cx">                         } else if (!strcmp(var, "port")) {
</span><span class="lines">@@ -1489,6 +1678,7 @@
</span><span class="cx">         }
</span><span class="cx">
</span><span class="cx">         /* Free dynamically allocated strings */
</span><ins>+        switch_safe_free(globals.domain);
</ins><span class="cx">         switch_safe_free(globals.ip);
</span><span class="cx">         switch_safe_free(globals.dialplan);
</span><span class="cx">         switch_safe_free(globals.codec_string);
</span></span></pre>
</div>
</div>
<div id="footer">See you at ClueCon</div>
</body>
</html>