<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[Freeswitch-trunk][16168] </title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<div id="header">FreeSWITCH Subversion</div>
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://fisheye.freeswitch.org/changelog/FreeSWITCH?cs=16168">16168</a></dd>
<dt>Author</dt> <dd>jmesquita</dd>
<dt>Date</dt> <dd>2010-01-05 21:45:00 -0600 (Tue, 05 Jan 2010)</dd>
</dl>

<h3>Log Message</h3>
<pre>A couple of more changes to the portaudio configuration.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#freeswitchtrunkfscommprefdialogui">freeswitch/trunk/fscomm/prefdialog.ui</a></li>
<li><a href="#freeswitchtrunkfscommprefportaudiocpp">freeswitch/trunk/fscomm/prefportaudio.cpp</a></li>
<li><a href="#freeswitchtrunkfscommprefportaudioh">freeswitch/trunk/fscomm/prefportaudio.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="freeswitchtrunkfscommprefdialogui"></a>
<div class="modfile"><h4>Modified: freeswitch/trunk/fscomm/prefdialog.ui (16167 => 16168)</h4>
<pre class="diff"><span>
<span class="info">--- freeswitch/trunk/fscomm/prefdialog.ui        2010-01-06 03:04:04 UTC (rev 16167)
+++ freeswitch/trunk/fscomm/prefdialog.ui        2010-01-06 03:45:00 UTC (rev 16168)
</span><span class="lines">@@ -6,7 +6,7 @@
</span><span class="cx">    &lt;rect&gt;
</span><span class="cx">     &lt;x&gt;0&lt;/x&gt;
</span><span class="cx">     &lt;y&gt;0&lt;/y&gt;
</span><del>-    &lt;width&gt;661&lt;/width&gt;
</del><ins>+    &lt;width&gt;711&lt;/width&gt;
</ins><span class="cx">     &lt;height&gt;437&lt;/height&gt;
</span><span class="cx">    &lt;/rect&gt;
</span><span class="cx">   &lt;/property&gt;
</span><span class="lines">@@ -197,7 +197,27 @@
</span><span class="cx">            &lt;/widget&gt;
</span><span class="cx">           &lt;/item&gt;
</span><span class="cx">           &lt;item row=&quot;1&quot; column=&quot;1&quot;&gt;
</span><del>-           &lt;widget class=&quot;QComboBox&quot; name=&quot;PaOutdevCombo&quot;/&gt;
</del><ins>+           &lt;layout class=&quot;QHBoxLayout&quot; name=&quot;horizontalLayout_3&quot;&gt;
+            &lt;item&gt;
+             &lt;widget class=&quot;QComboBox&quot; name=&quot;PaOutdevCombo&quot;/&gt;
+            &lt;/item&gt;
+            &lt;item&gt;
+             &lt;widget class=&quot;QPushButton&quot; name=&quot;PaOutdevTestBtn&quot;&gt;
+              &lt;property name=&quot;enabled&quot;&gt;
+               &lt;bool&gt;false&lt;/bool&gt;
+              &lt;/property&gt;
+              &lt;property name=&quot;maximumSize&quot;&gt;
+               &lt;size&gt;
+                &lt;width&gt;86&lt;/width&gt;
+                &lt;height&gt;27&lt;/height&gt;
+               &lt;/size&gt;
+              &lt;/property&gt;
+              &lt;property name=&quot;text&quot;&gt;
+               &lt;string&gt;Test&lt;/string&gt;
+              &lt;/property&gt;
+             &lt;/widget&gt;
+            &lt;/item&gt;
+           &lt;/layout&gt;
</ins><span class="cx">           &lt;/item&gt;
</span><span class="cx">           &lt;item row=&quot;2&quot; column=&quot;0&quot;&gt;
</span><span class="cx">            &lt;widget class=&quot;QLabel&quot; name=&quot;label_9&quot;&gt;
</span><span class="lines">@@ -207,7 +227,27 @@
</span><span class="cx">            &lt;/widget&gt;
</span><span class="cx">           &lt;/item&gt;
</span><span class="cx">           &lt;item row=&quot;2&quot; column=&quot;1&quot;&gt;
</span><del>-           &lt;widget class=&quot;QComboBox&quot; name=&quot;PaRingdevCombo&quot;/&gt;
</del><ins>+           &lt;layout class=&quot;QHBoxLayout&quot; name=&quot;horizontalLayout_2&quot;&gt;
+            &lt;item&gt;
+             &lt;widget class=&quot;QComboBox&quot; name=&quot;PaRingdevCombo&quot;/&gt;
+            &lt;/item&gt;
+            &lt;item&gt;
+             &lt;widget class=&quot;QPushButton&quot; name=&quot;PaRingdevTestBtn&quot;&gt;
+              &lt;property name=&quot;enabled&quot;&gt;
+               &lt;bool&gt;false&lt;/bool&gt;
+              &lt;/property&gt;
+              &lt;property name=&quot;maximumSize&quot;&gt;
+               &lt;size&gt;
+                &lt;width&gt;86&lt;/width&gt;
+                &lt;height&gt;27&lt;/height&gt;
+               &lt;/size&gt;
+              &lt;/property&gt;
+              &lt;property name=&quot;text&quot;&gt;
+               &lt;string&gt;Test&lt;/string&gt;
+              &lt;/property&gt;
+             &lt;/widget&gt;
+            &lt;/item&gt;
+           &lt;/layout&gt;
</ins><span class="cx">           &lt;/item&gt;
</span><span class="cx">          &lt;/layout&gt;
</span><span class="cx">         &lt;/widget&gt;
</span><span class="lines">@@ -217,7 +257,7 @@
</span><span class="cx">          &lt;property name=&quot;title&quot;&gt;
</span><span class="cx">           &lt;string&gt;Files&lt;/string&gt;
</span><span class="cx">          &lt;/property&gt;
</span><del>-         &lt;layout class=&quot;QGridLayout&quot; name=&quot;gridLayout&quot;&gt;
</del><ins>+         &lt;layout class=&quot;QFormLayout&quot; name=&quot;formLayout_5&quot;&gt;
</ins><span class="cx">           &lt;item row=&quot;0&quot; column=&quot;0&quot;&gt;
</span><span class="cx">            &lt;widget class=&quot;QLabel&quot; name=&quot;label_10&quot;&gt;
</span><span class="cx">             &lt;property name=&quot;text&quot;&gt;
</span><span class="lines">@@ -226,11 +266,22 @@
</span><span class="cx">            &lt;/widget&gt;
</span><span class="cx">           &lt;/item&gt;
</span><span class="cx">           &lt;item row=&quot;0&quot; column=&quot;1&quot;&gt;
</span><del>-           &lt;widget class=&quot;QLineEdit&quot; name=&quot;PaRingFileEdit&quot;&gt;
-            &lt;property name=&quot;text&quot;&gt;
-             &lt;string&gt;tone_stream://%(2000,4000,440.0,480.0);loops=20&lt;/string&gt;
-            &lt;/property&gt;
-           &lt;/widget&gt;
</del><ins>+           &lt;layout class=&quot;QHBoxLayout&quot; name=&quot;horizontalLayout_4&quot;&gt;
+            &lt;item&gt;
+             &lt;widget class=&quot;QLineEdit&quot; name=&quot;PaRingFileEdit&quot;&gt;
+              &lt;property name=&quot;text&quot;&gt;
+               &lt;string&gt;tone_stream://%(2000,4000,440.0,480.0);loops=20&lt;/string&gt;
+              &lt;/property&gt;
+             &lt;/widget&gt;
+            &lt;/item&gt;
+            &lt;item&gt;
+             &lt;widget class=&quot;QPushButton&quot; name=&quot;PaRingFileBtn&quot;&gt;
+              &lt;property name=&quot;text&quot;&gt;
+               &lt;string&gt;Open&lt;/string&gt;
+              &lt;/property&gt;
+             &lt;/widget&gt;
+            &lt;/item&gt;
+           &lt;/layout&gt;
</ins><span class="cx">           &lt;/item&gt;
</span><span class="cx">           &lt;item row=&quot;1&quot; column=&quot;0&quot;&gt;
</span><span class="cx">            &lt;widget class=&quot;QLabel&quot; name=&quot;label_12&quot;&gt;
</span><span class="lines">@@ -240,7 +291,11 @@
</span><span class="cx">            &lt;/widget&gt;
</span><span class="cx">           &lt;/item&gt;
</span><span class="cx">           &lt;item row=&quot;1&quot; column=&quot;1&quot;&gt;
</span><del>-           &lt;widget class=&quot;QSpinBox&quot; name=&quot;PaRingIntervalSpin&quot;/&gt;
</del><ins>+           &lt;widget class=&quot;QSpinBox&quot; name=&quot;PaRingIntervalSpin&quot;&gt;
+            &lt;property name=&quot;value&quot;&gt;
+             &lt;number&gt;5&lt;/number&gt;
+            &lt;/property&gt;
+           &lt;/widget&gt;
</ins><span class="cx">           &lt;/item&gt;
</span><span class="cx">           &lt;item row=&quot;2&quot; column=&quot;0&quot;&gt;
</span><span class="cx">            &lt;widget class=&quot;QLabel&quot; name=&quot;label_11&quot;&gt;
</span><span class="lines">@@ -250,7 +305,22 @@
</span><span class="cx">            &lt;/widget&gt;
</span><span class="cx">           &lt;/item&gt;
</span><span class="cx">           &lt;item row=&quot;2&quot; column=&quot;1&quot;&gt;
</span><del>-           &lt;widget class=&quot;QLineEdit&quot; name=&quot;PaHoldFileEdit&quot;/&gt;
</del><ins>+           &lt;layout class=&quot;QHBoxLayout&quot; name=&quot;horizontalLayout&quot;&gt;
+            &lt;item&gt;
+             &lt;widget class=&quot;QLineEdit&quot; name=&quot;PaHoldFileEdit&quot;&gt;
+              &lt;property name=&quot;readOnly&quot;&gt;
+               &lt;bool&gt;true&lt;/bool&gt;
+              &lt;/property&gt;
+             &lt;/widget&gt;
+            &lt;/item&gt;
+            &lt;item&gt;
+             &lt;widget class=&quot;QPushButton&quot; name=&quot;PaHoldFileBtn&quot;&gt;
+              &lt;property name=&quot;text&quot;&gt;
+               &lt;string&gt;Open&lt;/string&gt;
+              &lt;/property&gt;
+             &lt;/widget&gt;
+            &lt;/item&gt;
+           &lt;/layout&gt;
</ins><span class="cx">           &lt;/item&gt;
</span><span class="cx">          &lt;/layout&gt;
</span><span class="cx">         &lt;/widget&gt;
</span></span></pre></div>
<a id="freeswitchtrunkfscommprefportaudiocpp"></a>
<div class="modfile"><h4>Modified: freeswitch/trunk/fscomm/prefportaudio.cpp (16167 => 16168)</h4>
<pre class="diff"><span>
<span class="info">--- freeswitch/trunk/fscomm/prefportaudio.cpp        2010-01-06 03:04:04 UTC (rev 16167)
+++ freeswitch/trunk/fscomm/prefportaudio.cpp        2010-01-06 03:45:00 UTC (rev 16168)
</span><span class="lines">@@ -7,8 +7,57 @@
</span><span class="cx">         _ui(ui)
</span><span class="cx"> {
</span><span class="cx">     _settings = new QSettings();
</span><ins>+    connect(_ui-&gt;PaRingFileBtn, SIGNAL(clicked()), this, SLOT(ringFileChoose()));
+    connect(_ui-&gt;PaHoldFileBtn, SIGNAL(clicked()), this, SLOT(holdFileChoose()));
+    connect(_ui-&gt;PaOutdevCombo, SIGNAL(currentIndexChanged(int)), this, SLOT(outdevChangeDev(int)));
+    connect(_ui-&gt;PaRingdevCombo, SIGNAL(currentIndexChanged(int)), this, SLOT(ringdevChangeDev(int)));
</ins><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void PrefPortaudio::ringdevChangeDev(int dev)
+{
+    QString result;
+    if (g_FSHost.sendCmd(&quot;pa&quot;, QString(&quot;ringdev #%1&quot;).arg(dev).toAscii().constData(), &amp;result) != SWITCH_STATUS_SUCCESS)
+    {
+        switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, &quot;Error setting ringdev to #%d on mod_portaudio!\n&quot;, dev);
+        QMessageBox::critical(0, tr(&quot;Unable to change device.&quot;),
+                              tr(&quot;There was an error changing the ringdev.\nPlease report this bug.&quot;),
+                              QMessageBox::Ok);
+
+    }
+}
+
+void PrefPortaudio::outdevChangeDev(int dev)
+{
+    QString result;
+    if (g_FSHost.sendCmd(&quot;pa&quot;, QString(&quot;outdev #%1&quot;).arg(dev).toAscii().constData(), &amp;result) != SWITCH_STATUS_SUCCESS)
+    {
+        switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, &quot;Error setting outdev to #%d on mod_portaudio!\n&quot;, dev);
+        QMessageBox::critical(0, tr(&quot;Unable to change device.&quot;),
+                              tr(&quot;There was an error changing the outdev.\nPlease report this bug.&quot;),
+                              QMessageBox::Ok);
+    }
+}
+
+void PrefPortaudio::holdFileChoose()
+{
+    QString fileName = QFileDialog::getOpenFileName(0,
+                                                    tr(&quot;Select file&quot;),
+                                                    QDir::homePath(),
+                                                    NULL);
+    if (!fileName.isNull())
+        _ui-&gt;PaHoldFileEdit-&gt;setText(fileName);
+}
+
+void PrefPortaudio::ringFileChoose()
+{
+    QString fileName = QFileDialog::getOpenFileName(0,
+                                                    tr(&quot;Select file&quot;),
+                                                    QDir::homePath(),
+                                                    NULL);
+    if (!fileName.isNull())
+        _ui-&gt;PaRingFileEdit-&gt;setText(fileName);
+}
+
</ins><span class="cx"> void PrefPortaudio::writeConfig()
</span><span class="cx"> {
</span><span class="cx">     _settings-&gt;beginGroup(&quot;FreeSWITCH/conf&quot;);
</span><span class="lines">@@ -79,33 +128,11 @@
</span><span class="cx"> 
</span><span class="cx">     if (noutdev!= outdev)
</span><span class="cx">     {
</span><del>-        if (g_FSHost.sendCmd(&quot;pa&quot;, QString(&quot;outdev #%1&quot;).arg(noutdev).toAscii().constData(), &amp;result) == SWITCH_STATUS_SUCCESS)
-        {
-            _settings-&gt;setValue(&quot;outdev&quot;, noutdev);
-        }
-        else
-        {
-            switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, &quot;Error setting outdev from #%d to #%d on mod_portaudio!\n&quot;,
-                              outdev, noutdev);
-            QMessageBox::critical(0, tr(&quot;Unable to save settings&quot;),
-                                  tr(&quot;There was an error changing the outdev.\nPlease report this bug.&quot;),
-                                  QMessageBox::Ok);
-        }
</del><ins>+        _settings-&gt;setValue(&quot;outdev&quot;, noutdev);
</ins><span class="cx">     }
</span><span class="cx">     if (nringdev != ringdev)
</span><span class="cx">     {
</span><del>-        if (g_FSHost.sendCmd(&quot;pa&quot;, QString(&quot;ringdev #%1&quot;).arg(nringdev).toAscii().constData(), &amp;result) == SWITCH_STATUS_SUCCESS)
-        {
-            _settings-&gt;setValue(&quot;ringdev&quot;, nringdev);
-        }
-        else
-        {
-            switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, &quot;Error setting ringdev from #%d to #%d on mod_portaudio!\n&quot;,
-                              nringdev, nringdev);
-            QMessageBox::critical(0, tr(&quot;Unable to save settings&quot;),
-                                  tr(&quot;There was an error changing the ringdev.\nPlease report this bug.&quot;),
-                                  QMessageBox::Ok);
-        }
</del><ins>+        _settings-&gt;setValue(&quot;ringdev&quot;, nringdev);
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     _settings-&gt;endGroup();
</span></span></pre></div>
<a id="freeswitchtrunkfscommprefportaudioh"></a>
<div class="modfile"><h4>Modified: freeswitch/trunk/fscomm/prefportaudio.h (16167 => 16168)</h4>
<pre class="diff"><span>
<span class="info">--- freeswitch/trunk/fscomm/prefportaudio.h        2010-01-06 03:04:04 UTC (rev 16167)
+++ freeswitch/trunk/fscomm/prefportaudio.h        2010-01-06 03:45:00 UTC (rev 16168)
</span><span class="lines">@@ -15,6 +15,12 @@
</span><span class="cx">     void writeConfig();
</span><span class="cx">     void readConfig();
</span><span class="cx"> 
</span><ins>+private slots:
+    void ringFileChoose();
+    void holdFileChoose();
+    void outdevChangeDev(int);
+    void ringdevChangeDev(int);
+
</ins><span class="cx"> private:
</span><span class="cx">     void getPaDevlist(void);
</span><span class="cx">     QSettings *_settings;
</span></span></pre>
</div>
</div>
<div id="footer">See you at ClueCon</div>

</body>
</html>