<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[Freeswitch-trunk][15028] </title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<div id="header">FreeSWITCH Subversion</div>
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://fisheye.freeswitch.org/changelog/FreeSWITCH?cs=15028">15028</a></dd>
<dt>Author</dt> <dd>anthm</dd>
<dt>Date</dt> <dd>2009-09-30 18:50:51 -0500 (Wed, 30 Sep 2009)</dd>
</dl>
<h3>Log Message</h3>
<pre><a href="http://jira.freeswitch.org/browse/FSCORE-452">FSCORE-452</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#freeswitchtrunksrcmodapplicationsmod_dptoolsmod_dptoolsc">freeswitch/trunk/src/mod/applications/mod_dptools/mod_dptools.c</a></li>
<li><a href="#freeswitchtrunksrcswitch_core_ioc">freeswitch/trunk/src/switch_core_io.c</a></li>
<li><a href="#freeswitchtrunksrcswitch_ivr_bridgec">freeswitch/trunk/src/switch_ivr_bridge.c</a></li>
<li><a href="#freeswitchtrunksrcswitch_ivr_originatec">freeswitch/trunk/src/switch_ivr_originate.c</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="freeswitchtrunksrcmodapplicationsmod_dptoolsmod_dptoolsc"></a>
<div class="modfile"><h4>Modified: freeswitch/trunk/src/mod/applications/mod_dptools/mod_dptools.c (15027 => 15028)</h4>
<pre class="diff"><span>
<span class="info">--- freeswitch/trunk/src/mod/applications/mod_dptools/mod_dptools.c        2009-09-30 23:28:49 UTC (rev 15027)
+++ freeswitch/trunk/src/mod/applications/mod_dptools/mod_dptools.c        2009-09-30 23:50:51 UTC (rev 15028)
</span><span class="lines">@@ -2102,28 +2102,6 @@
</span><span class="cx">         continue_on_fail = switch_channel_get_variable(caller_channel, "continue_on_fail");
</span><span class="cx">         failure_causes = switch_channel_get_variable(caller_channel, "failure_causes");
</span><span class="cx">
</span><del>-        if ((var = switch_channel_get_variable(caller_channel, SWITCH_PROXY_MEDIA_VARIABLE)) && switch_true(var)) {
-                switch_channel_set_flag(caller_channel, CF_PROXY_MEDIA);
-        }
-
-        if (switch_channel_test_flag(caller_channel, CF_PROXY_MODE)
-                || ((var = switch_channel_get_variable(caller_channel, SWITCH_BYPASS_MEDIA_VARIABLE)) && switch_true(var))) {
-                if (!switch_channel_test_flag(caller_channel, CF_ANSWERED)
-                        && !switch_channel_test_flag(caller_channel, CF_EARLY_MEDIA)) {
-                        switch_channel_set_flag(caller_channel, CF_PROXY_MODE);
-                } else {
-                        if (switch_channel_test_flag(caller_channel, CF_PROXY_MODE)) {
-                                switch_ivr_media(switch_core_session_get_uuid(session), SMF_REBRIDGE);
-                                switch_channel_set_flag(caller_channel, CF_PROXY_MODE);
-                        } else {
-                                switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_DEBUG, "Channel is already up, delaying proxy mode 'till both legs are answered.\n");
-                                switch_channel_set_variable(caller_channel, "bypass_media_after_bridge", "true");
-                                switch_channel_set_variable(caller_channel, SWITCH_BYPASS_MEDIA_VARIABLE, NULL);
-                                switch_channel_clear_flag(caller_channel, CF_PROXY_MODE);
-                        }
-                }
-        }
-
</del><span class="cx">         if (switch_ivr_originate(session, &peer_session, &cause, data, timelimit, NULL, NULL, NULL, NULL, NULL, SOF_NONE) != SWITCH_STATUS_SUCCESS) {
</span><span class="cx">                 switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_INFO, "Originate Failed. Cause: %s\n", switch_channel_cause2str(cause));
</span><span class="cx">
</span></span></pre></div>
<a id="freeswitchtrunksrcswitch_core_ioc"></a>
<div class="modfile"><h4>Modified: freeswitch/trunk/src/switch_core_io.c (15027 => 15028)</h4>
<pre class="diff"><span>
<span class="info">--- freeswitch/trunk/src/switch_core_io.c        2009-09-30 23:28:49 UTC (rev 15027)
+++ freeswitch/trunk/src/switch_core_io.c        2009-09-30 23:50:51 UTC (rev 15028)
</span><span class="lines">@@ -112,6 +112,8 @@
</span><span class="cx">
</span><span class="cx">         if (!(session->read_codec && session->read_codec->implementation && switch_core_codec_ready(session->read_codec))) {
</span><span class="cx">                 if (switch_channel_test_flag(session->channel, CF_PROXY_MODE) || switch_channel_get_state(session->channel) == CS_HIBERNATE) {
</span><ins>+                        switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_CRIT, "%s reading on a session with no media!\n", switch_channel_get_name(session->channel));
+                        switch_cond_next();
</ins><span class="cx">                         *frame = &runtime.dummy_cng_frame;
</span><span class="cx">                         return SWITCH_STATUS_SUCCESS;
</span><span class="cx">                 }
</span></span></pre></div>
<a id="freeswitchtrunksrcswitch_ivr_bridgec"></a>
<div class="modfile"><h4>Modified: freeswitch/trunk/src/switch_ivr_bridge.c (15027 => 15028)</h4>
<pre class="diff"><span>
<span class="info">--- freeswitch/trunk/src/switch_ivr_bridge.c        2009-09-30 23:28:49 UTC (rev 15027)
+++ freeswitch/trunk/src/switch_ivr_bridge.c        2009-09-30 23:50:51 UTC (rev 15028)
</span><span class="lines">@@ -815,6 +815,11 @@
</span><span class="cx">         const char *var;
</span><span class="cx">         switch_call_cause_t cause;
</span><span class="cx">
</span><ins>+        if (switch_channel_test_flag(caller_channel, CF_PROXY_MODE)) {
+                switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_DEBUG, "Call has no media... Redirecting to signal bridge.\n");
+                return switch_ivr_signal_bridge(session, peer_session);
+        }
+
</ins><span class="cx">         switch_channel_set_flag(caller_channel, CF_ORIGINATOR);
</span><span class="cx">
</span><span class="cx">         b_leg->session = peer_session;
</span></span></pre></div>
<a id="freeswitchtrunksrcswitch_ivr_originatec"></a>
<div class="modfile"><h4>Modified: freeswitch/trunk/src/switch_ivr_originate.c (15027 => 15028)</h4>
<pre class="diff"><span>
<span class="info">--- freeswitch/trunk/src/switch_ivr_originate.c        2009-09-30 23:28:49 UTC (rev 15027)
+++ freeswitch/trunk/src/switch_ivr_originate.c        2009-09-30 23:50:51 UTC (rev 15028)
</span><span class="lines">@@ -999,11 +999,39 @@
</span><span class="cx">         int local_clobber = 0;
</span><span class="cx">         const char *cancel_key = NULL;
</span><span class="cx">
</span><ins>+        if (session) {
+                caller_channel = switch_core_session_get_channel(session);
+                oglobals.session = session;
+
+                if (switch_true(switch_channel_get_variable(caller_channel, SWITCH_PROXY_MEDIA_VARIABLE))) {
+                        switch_channel_set_flag(caller_channel, CF_PROXY_MEDIA);
+                }
+
+                if (switch_channel_test_flag(caller_channel, CF_PROXY_MODE)
+                        || (switch_true(switch_channel_get_variable(caller_channel, SWITCH_BYPASS_MEDIA_VARIABLE)))) {
+                        if (!switch_channel_test_flag(caller_channel, CF_ANSWERED)
+                                && !switch_channel_test_flag(caller_channel, CF_EARLY_MEDIA)) {
+                                switch_channel_set_flag(caller_channel, CF_PROXY_MODE);
+                        } else {
+                                if (switch_channel_test_flag(caller_channel, CF_PROXY_MODE)) {
+                                        switch_ivr_media(switch_core_session_get_uuid(session), SMF_REBRIDGE);
+                                        switch_channel_set_flag(caller_channel, CF_PROXY_MODE);
+                                } else {
+                                        switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_DEBUG, "Channel is already up, delaying proxy mode 'till both legs are answered.\n");
+                                        switch_channel_set_variable(caller_channel, "bypass_media_after_bridge", "true");
+                                        switch_channel_set_variable(caller_channel, SWITCH_BYPASS_MEDIA_VARIABLE, NULL);
+                                        switch_channel_clear_flag(caller_channel, CF_PROXY_MODE);
+                                }
+                        }
+                }
+        }
+
+        
</ins><span class="cx">         oglobals.idx = IDX_NADA;
</span><span class="cx">         oglobals.early_ok = 1;
</span><del>-        oglobals.session = session;
</del><span class="cx">
</span><span class="cx">
</span><ins>+
</ins><span class="cx">         *bleg = NULL;
</span><span class="cx">
</span><span class="cx">         switch_zmalloc(write_frame.data, SWITCH_RECOMMENDED_BUFFER_SIZE);
</span><span class="lines">@@ -1107,8 +1135,6 @@
</span><span class="cx">                 switch_event_header_t *hi;
</span><span class="cx">                 const char *cdr_total_var;
</span><span class="cx">
</span><del>-                caller_channel = switch_core_session_get_channel(oglobals.session);
-
</del><span class="cx">                 if ((cdr_total_var = switch_channel_get_variable(caller_channel, "failed_xml_cdr_total"))) {
</span><span class="cx">                         int tmp = atoi(cdr_total_var);
</span><span class="cx">                         if (tmp > 0) {
</span></span></pre>
</div>
</div>
<div id="footer">See you at ClueCon</div>
</body>
</html>