<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[Freeswitch-trunk][14884] </title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<div id="header">FreeSWITCH Subversion</div>
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://fisheye.freeswitch.org/changelog/FreeSWITCH?cs=14884">14884</a></dd>
<dt>Author</dt> <dd>gmaruzz</dd>
<dt>Date</dt> <dd>2009-09-16 10:35:10 -0500 (Wed, 16 Sep 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>skypiax: now outbound chatmessages follow the standard path, you can send them with: chat,&lt;proto&gt;|&lt;from&gt;|&lt;to&gt;|&lt;message&gt; or with: skypiax_chat,&lt;interfacename&gt; &lt;to&gt; &lt;text&gt;. First form is the standard, will pick the first interface connected to the skypeusername 'from'. Second form is skypiax specific, let you choose which interface the message will be sent from (and implicitly the skypeusername [each interface is connected to one skypeusername - possibly many interfaces to the same skypeusername]</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#freeswitchtrunksrcmodendpointsmod_skypiaxmod_skypiaxc">freeswitch/trunk/src/mod/endpoints/mod_skypiax/mod_skypiax.c</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="freeswitchtrunksrcmodendpointsmod_skypiaxmod_skypiaxc"></a>
<div class="modfile"><h4>Modified: freeswitch/trunk/src/mod/endpoints/mod_skypiax/mod_skypiax.c (14883 => 14884)</h4>
<pre class="diff"><span>
<span class="info">--- freeswitch/trunk/src/mod/endpoints/mod_skypiax/mod_skypiax.c        2009-09-16 15:06:52 UTC (rev 14883)
+++ freeswitch/trunk/src/mod/endpoints/mod_skypiax/mod_skypiax.c        2009-09-16 15:35:10 UTC (rev 14884)
</span><span class="lines">@@ -1398,10 +1398,124 @@
</span><span class="cx"> 
</span><span class="cx">         return SWITCH_STATUS_SUCCESS;
</span><span class="cx"> }
</span><ins>+static switch_status_t chat_send(const char *proto, const char *from, const char *to, const char *subject, const char *body, const char *type, const char *hint)
+{
+        //char *user, *host, *f_user = NULL, *ffrom = NULL, *f_host = NULL, *f_resource = NULL;
+        char *user, *host, *f_user = NULL, *f_host = NULL, *f_resource = NULL;
+        //mdl_profile_t *profile = NULL;
+        private_t * tech_pvt=NULL;
+        int i=0, found=0, tried=0;
+        char skype_msg[1024];
</ins><span class="cx"> 
</span><ins>+        switch_assert(proto != NULL);
+
+        DEBUGA_SKYPE(&quot;chat_send(proto=%s, from=%s, to=%s, subject=%s, body=%s, type=%s, hint=%s)\n&quot;, SKYPIAX_P_LOG, proto, from, to, subject, body, type, hint?hint:&quot;NULL&quot;);
+
+        if (!to || !strlen(to)) {
+                ERRORA(&quot;Missing To: header.\n&quot;, SKYPIAX_P_LOG);
+                return SWITCH_STATUS_SUCCESS;
+        }
+
+        if ((!from &amp;&amp; !hint) || (!strlen(from) &amp;&amp; !strlen(hint)) ) {
+                ERRORA(&quot;Missing From: AND Hint: headers.\n&quot;, SKYPIAX_P_LOG);
+                return SWITCH_STATUS_SUCCESS;
+        }
+
+        if (from &amp;&amp; (f_user = strdup(from))) {
+                if ((f_host = strchr(f_user, '@'))) {
+                        *f_host++ = '\0';
+                        if ((f_resource = strchr(f_host, '/'))) {
+                                *f_resource++ = '\0';
+                        }
+                }
+        }
+
+        if (to &amp;&amp; (user = strdup(to))) {
+                if ((host = strchr(user, '@'))) {
+                        *host++ = '\0';
+                }
+
+                //if (!strcmp(proto, MDL_CHAT_PROTO)) {
+
+        DEBUGA_SKYPE(&quot;chat_send(proto=%s, from=%s, to=%s, subject=%s, body=%s, type=%s, hint=%s)\n&quot;, SKYPIAX_P_LOG, proto, from, to, subject, body, type, hint?hint:&quot;NULL&quot;);
+                        if (hint &amp;&amp; strlen(hint)) {
+                                //in hint we receive the interface name to use
+                                for (i = 0; !found &amp;&amp; i &lt; SKYPIAX_MAX_INTERFACES; i++) {
+                                        if (strlen(globals.SKYPIAX_INTERFACES[i].name)
+                                                        &amp;&amp; (strncmp(globals.SKYPIAX_INTERFACES[i].name, hint, strlen(hint)) == 0)) {
+                                                tech_pvt = &amp;globals.SKYPIAX_INTERFACES[i];
+                                                DEBUGA_SKYPE(&quot;Using interface: globals.SKYPIAX_INTERFACES[%d].name=|||%s|||\n&quot;, SKYPIAX_P_LOG, i, globals.SKYPIAX_INTERFACES[i].name);
+                                                found = 1;
+                                                break;
+                                        }
+                                }
+                        } else {
+                                //we have no a predefined interface name to use (hint is NULL), so let's choose an interface from the username (from)
+                                for (i = 0; !found &amp;&amp; i &lt; SKYPIAX_MAX_INTERFACES; i++) {
+                                        if (strlen(globals.SKYPIAX_INTERFACES[i].name)
+                                                        &amp;&amp; (strncmp(globals.SKYPIAX_INTERFACES[i].skype_user, from, strlen(from)) == 0)) {
+                                                tech_pvt = &amp;globals.SKYPIAX_INTERFACES[i];
+                                                DEBUGA_SKYPE(&quot;Using interface: globals.SKYPIAX_INTERFACES[%d].name=|||%s|||\n&quot;, SKYPIAX_P_LOG, i, globals.SKYPIAX_INTERFACES[i].name);
+                                                found = 1;
+                                                break;
+                                        }
+                                }
+                        }
+                        if (!found) {
+                                ERRORA(&quot;ERROR: A Skypiax interface with name='%s' or one with skypeuser='%s' was not found\n&quot;, SKYPIAX_P_LOG, hint?hint:&quot;NULL&quot;, from?from:&quot;NULL&quot;);
+                                goto end;
+                        } else {
+
+                                snprintf(skype_msg, sizeof(skype_msg), &quot;CHAT CREATE %s&quot;, to);
+                                skypiax_signaling_write(tech_pvt, skype_msg);
+                                usleep(100);
+                        }
+                //} else {
+                        //FIXME don't know how to do here, let's hope this is correct
+                        //char *p;
+                        //ffrom = switch_mprintf(&quot;%s+%s&quot;, proto, from);
+                        //from = ffrom;
+                        //if ((p = strchr(from, '/'))) {
+                                //*p = '\0';
+                        //}
+        //NOTICA(&quot;chat_send(proto=%s, from=%s, to=%s, subject=%s, body=%s, type=%s, hint=%s)\n&quot;, SKYPIAX_P_LOG, proto, from, to, subject, body, type, hint?hint:&quot;NULL&quot;);
+                        //switch_core_chat_send(proto, proto, from, to, subject, body, type, hint);
+                        //return SWITCH_STATUS_SUCCESS;
+                //}
+
+                found=0;
+
+                while(!found){
+                        for(i=0; i&lt;MAX_CHATS; i++){
+                                if(!strcmp(tech_pvt-&gt;chats[i].dialog_partner, to) ){
+                                        snprintf(skype_msg, sizeof(skype_msg), &quot;CHATMESSAGE %s %s&quot;, tech_pvt-&gt;chats[i].chatname, body);
+                                        skypiax_signaling_write(tech_pvt, skype_msg);
+                                        found=1;
+                                        break;
+                                }
+                        }
+                        if(found){
+                                break;
+                        }
+                        if(tried &gt; 1000){
+                                ERRORA(&quot;No chat with dialog_partner='%s' was found\n&quot;, SKYPIAX_P_LOG, to);
+                                break;
+                        }
+                        usleep(1000);
+                }
+
+        }
+end:
+        switch_safe_free(user);
+        switch_safe_free(f_user);
+        return SWITCH_STATUS_SUCCESS;
+}
+
+
</ins><span class="cx"> SWITCH_MODULE_LOAD_FUNCTION(mod_skypiax_load)
</span><span class="cx"> {
</span><span class="cx">         switch_api_interface_t *commands_api_interface;
</span><ins>+        switch_chat_interface_t *chat_interface;
</ins><span class="cx"> 
</span><span class="cx">         skypiax_module_pool = pool;
</span><span class="cx">         memset(&amp;globals, '\0', sizeof(globals));
</span><span class="lines">@@ -1429,7 +1543,9 @@
</span><span class="cx">                 SWITCH_ADD_API(commands_api_interface, &quot;sk&quot;, &quot;Skypiax console commands&quot;, sk_function, SK_SYNTAX);
</span><span class="cx">                 SWITCH_ADD_API(commands_api_interface, &quot;skypiax&quot;, &quot;Skypiax interface commands&quot;, skypiax_function, SKYPIAX_SYNTAX);
</span><span class="cx">                 SWITCH_ADD_API(commands_api_interface, &quot;skypiax_chat&quot;, &quot;Skypiax_chat interface remote_skypename TEXT&quot;, skypiax_chat_function, SKYPIAX_CHAT_SYNTAX);
</span><ins>+                SWITCH_ADD_CHAT(chat_interface, MDL_CHAT_PROTO, chat_send);
</ins><span class="cx"> 
</span><ins>+
</ins><span class="cx">                 /* indicate that the module should continue to be loaded */
</span><span class="cx">                 return SWITCH_STATUS_SUCCESS;
</span><span class="cx">         } else
</span><span class="lines">@@ -1908,86 +2024,7 @@
</span><span class="cx"> 
</span><span class="cx">         return SWITCH_STATUS_SUCCESS;
</span><span class="cx"> }
</span><del>-SWITCH_STANDARD_API(skypiax_chat_function)
-{
-        char *mycmd = NULL, *argv[10] = { 0 };
-        int argc = 0;
-        private_t *tech_pvt = NULL;
-        int tried =0;
-        int i;
-        int found = 0;
-        char skype_msg[1024];
</del><span class="cx"> 
</span><del>-        if (!switch_strlen_zero(cmd) &amp;&amp; (mycmd = strdup(cmd))) {
-                argc = switch_separate_string(mycmd, ' ', argv, (sizeof(argv) / sizeof(argv[0])));
-        }
-
-        if (!argc) {
-                stream-&gt;write_function(stream, &quot;ERROR, usage: %s&quot;, SKYPIAX_CHAT_SYNTAX);
-                goto end;
-        }
-
-        if (argc &lt; 3) {
-                stream-&gt;write_function(stream, &quot;ERROR, usage: %s&quot;, SKYPIAX_CHAT_SYNTAX);
-                goto end;
-        }
-
-        if (argv[0]) {
-
-                for (i = 0; !found &amp;&amp; i &lt; SKYPIAX_MAX_INTERFACES; i++) {
-                        /* we've been asked for a normal interface name, or we have not found idle interfaces to serve as the &quot;ANY&quot; interface */
-                        if (strlen(globals.SKYPIAX_INTERFACES[i].name)
-                                        &amp;&amp; (strncmp(globals.SKYPIAX_INTERFACES[i].name, argv[0], strlen(argv[0])) == 0)) {
-                                tech_pvt = &amp;globals.SKYPIAX_INTERFACES[i];
-                                stream-&gt;write_function(stream, &quot;Using interface: globals.SKYPIAX_INTERFACES[%d].name=|||%s|||\n&quot;, i, globals.SKYPIAX_INTERFACES[i].name);
-                                found = 1;
-                                break;
-                        }
-
-                }
-                if (!found) {
-                        stream-&gt;write_function(stream, &quot;ERROR: A Skypiax interface with name='%s' was not found\n&quot;, argv[0]);
-                        goto end;
-                } else {
-                        char skype_msg[256];
-                        //NOTICA(&quot;TEXT is: %s\n&quot;, SKYPIAX_P_LOG, (char *) &amp;cmd[strlen(argv[0]) + 1 + strlen(argv[1]) + 1] );
-                        snprintf(skype_msg, sizeof(skype_msg), &quot;CHAT CREATE %s&quot;, argv[1]);
-                        skypiax_signaling_write(tech_pvt, skype_msg);
-                        usleep(100);
-                }
-        } else {
-                stream-&gt;write_function(stream, &quot;ERROR, usage: %s&quot;, SKYPIAX_CHAT_SYNTAX);
-        }
-
-
-        found=0;
-
-        while(!found){
-                for(i=0; i&lt;MAX_CHATS; i++){
-                        if(!strcmp(tech_pvt-&gt;chats[i].dialog_partner, argv[1]) ){
-                                snprintf(skype_msg, sizeof(skype_msg), &quot;CHATMESSAGE %s %s&quot;, tech_pvt-&gt;chats[i].chatname, (char *) &amp;cmd[strlen(argv[0]) + 1 + strlen(argv[1]) + 1]);
-                                skypiax_signaling_write(tech_pvt, skype_msg);
-                                found=1;
-                                break;
-                        }
-                }
-                if(found){
-                        break;
-                }
-                if(tried &gt; 1000){
-                        stream-&gt;write_function(stream, &quot;ERROR: no chat with dialog_partner='%s' was not found\n&quot;, argv[1]);
-                        break;
-                }
-                usleep(1000);
-        }
-
-end:
-        switch_safe_free(mycmd);
-
-        return SWITCH_STATUS_SUCCESS;
-}
-
-
</del><span class="cx"> SWITCH_STANDARD_API(skypiax_function)
</span><span class="cx"> {
</span><span class="cx">         char *mycmd = NULL, *argv[10] = { 0 };
</span><span class="lines">@@ -2301,6 +2338,97 @@
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> 
</span><ins>+SWITCH_STANDARD_API(skypiax_chat_function)
+{
+        char *mycmd = NULL, *argv[10] = { 0 };
+        int argc = 0;
+        private_t *tech_pvt = NULL;
+        //int tried =0;
+        int i;
+        int found = 0;
+        //char skype_msg[1024];
+
+        if (!switch_strlen_zero(cmd) &amp;&amp; (mycmd = strdup(cmd))) {
+                argc = switch_separate_string(mycmd, ' ', argv, (sizeof(argv) / sizeof(argv[0])));
+        }
+
+        if (!argc) {
+                stream-&gt;write_function(stream, &quot;ERROR, usage: %s&quot;, SKYPIAX_CHAT_SYNTAX);
+                goto end;
+        }
+
+        if (argc &lt; 3) {
+                stream-&gt;write_function(stream, &quot;ERROR, usage: %s&quot;, SKYPIAX_CHAT_SYNTAX);
+                goto end;
+        }
+
+        if (argv[0]) {
+                for (i = 0; !found &amp;&amp; i &lt; SKYPIAX_MAX_INTERFACES; i++) {
+                        /* we've been asked for a normal interface name, or we have not found idle interfaces to serve as the &quot;ANY&quot; interface */
+                        if (strlen(globals.SKYPIAX_INTERFACES[i].name)
+                                        &amp;&amp; (strncmp(globals.SKYPIAX_INTERFACES[i].name, argv[0], strlen(argv[0])) == 0)) {
+                                tech_pvt = &amp;globals.SKYPIAX_INTERFACES[i];
+                                stream-&gt;write_function(stream, &quot;Using interface: globals.SKYPIAX_INTERFACES[%d].name=|||%s|||\n&quot;, i, globals.SKYPIAX_INTERFACES[i].name);
+                                found = 1;
+                                break;
+                        }
+
+                }
+                if (!found) {
+                        stream-&gt;write_function(stream, &quot;ERROR: A Skypiax interface with name='%s' was not found\n&quot;, argv[0]);
+                        goto end;
+                } else {
+
+                        //chat_send(const char *proto, const char *from, const char *to, const char *subject, const char *body, const char *type, const char *hint);
+                        //chat_send(p*roto, const char *from, const char *to, const char *subject, const char *body, const char *type, const char *hint);
+                        //chat_send(MDL_CHAT_PROTO, tech_pvt-&gt;skype_user, argv[1], &quot;SIMPLE MESSAGE&quot;, switch_str_nil((char *) &amp;cmd[strlen(argv[0]) + 1 + strlen(argv[1]) + 1]), NULL, hint);
+
+                        NOTICA(&quot;chat_send(proto=%s, from=%s, to=%s, subject=%s, body=%s, type=NULL, hint=%s)\n&quot;, SKYPIAX_P_LOG, MDL_CHAT_PROTO, tech_pvt-&gt;skype_user, argv[1], &quot;SIMPLE MESSAGE&quot;, switch_str_nil((char *) &amp;cmd[strlen(argv[0]) + 1 + strlen(argv[1]) + 1]), tech_pvt-&gt;name);
+
+                        chat_send(MDL_CHAT_PROTO, tech_pvt-&gt;skype_user, argv[1], &quot;SIMPLE MESSAGE&quot;, switch_str_nil((char *) &amp;cmd[strlen(argv[0]) + 1 + strlen(argv[1]) + 1]), NULL, tech_pvt-&gt;name);
+
+                        //NOTICA(&quot;TEXT is: %s\n&quot;, SKYPIAX_P_LOG, (char *) &amp;cmd[strlen(argv[0]) + 1 + strlen(argv[1]) + 1] );
+                        //snprintf(skype_msg, sizeof(skype_msg), &quot;CHAT CREATE %s&quot;, argv[1]);
+                        //skypiax_signaling_write(tech_pvt, skype_msg);
+                        //usleep(100);
+                }
+        } else {
+                stream-&gt;write_function(stream, &quot;ERROR, usage: %s&quot;, SKYPIAX_CHAT_SYNTAX);
+                goto end;
+        }
+
+#ifdef NOTDEF
+
+        found=0;
+
+        while(!found){
+                for(i=0; i&lt;MAX_CHATS; i++){
+                        if(!strcmp(tech_pvt-&gt;chats[i].dialog_partner, argv[1]) ){
+                                snprintf(skype_msg, sizeof(skype_msg), &quot;CHATMESSAGE %s %s&quot;, tech_pvt-&gt;chats[i].chatname, (char *) &amp;cmd[strlen(argv[0]) + 1 + strlen(argv[1]) + 1]);
+                                skypiax_signaling_write(tech_pvt, skype_msg);
+                                found=1;
+                                break;
+                        }
+                }
+                if(found){
+                        break;
+                }
+                if(tried &gt; 1000){
+                        stream-&gt;write_function(stream, &quot;ERROR: no chat with dialog_partner='%s' was found\n&quot;, argv[1]);
+                        break;
+                }
+                usleep(1000);
+        }
+#endif //NOTDEF
+
+end:
+        switch_safe_free(mycmd);
+
+        return SWITCH_STATUS_SUCCESS;
+}
+
+
+
</ins><span class="cx"> /* For Emacs:
</span><span class="cx">  * Local Variables:
</span><span class="cx">  * mode:c
</span></span></pre>
</div>
</div>
<div id="footer">See you at ClueCon</div>

</body>
</html>