<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[Freeswitch-trunk][14212] </title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<div id="header">FreeSWITCH Subversion</div>
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://fisheye.freeswitch.org/changelog/FreeSWITCH?cs=14212">14212</a></dd>
<dt>Author</dt> <dd>jmesquita</dd>
<dt>Date</dt> <dd>2009-07-13 01:01:22 -0500 (Mon, 13 Jul 2009)</dd>
</dl>
<h3>Log Message</h3>
<pre>We are trying to cleanup right a QThread.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#freeswitchtrunkcontribjmesquitafsguiesl_connectioncpp">freeswitch/trunk/contrib/jmesquita/fsgui/esl_connection.cpp</a></li>
<li><a href="#freeswitchtrunkcontribjmesquitafsguiesl_connectionh">freeswitch/trunk/contrib/jmesquita/fsgui/esl_connection.h</a></li>
<li><a href="#freeswitchtrunkcontribjmesquitafsguifs_guicpp">freeswitch/trunk/contrib/jmesquita/fsgui/fs_gui.cpp</a></li>
<li><a href="#freeswitchtrunkcontribjmesquitafsguifs_guih">freeswitch/trunk/contrib/jmesquita/fsgui/fs_gui.h</a></li>
<li><a href="#freeswitchtrunkcontribjmesquitafsguifs_guiui">freeswitch/trunk/contrib/jmesquita/fsgui/fs_gui.ui</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="freeswitchtrunkcontribjmesquitafsguiesl_connectioncpp"></a>
<div class="modfile"><h4>Modified: freeswitch/trunk/contrib/jmesquita/fsgui/esl_connection.cpp (14211 => 14212)</h4>
<pre class="diff"><span>
<span class="info">--- freeswitch/trunk/contrib/jmesquita/fsgui/esl_connection.cpp 2009-07-13 04:29:55 UTC (rev 14211)
+++ freeswitch/trunk/contrib/jmesquita/fsgui/esl_connection.cpp 2009-07-13 06:01:22 UTC (rev 14212)
</span><span class="lines">@@ -1,6 +1,5 @@
</span><span class="cx"> #include "esl_oop.h"
</span><span class="cx"> #include "esl_connection.h"
</span><del>-#include <iostream>
</del><span class="cx">
</span><span class="cx"> eslConnectionManager::eslConnectionManager() {}
</span><span class="cx"> eslConnectionManager::eslConnectionManager(QString host, QString pass, QString port)
</span><span class="lines">@@ -10,11 +9,6 @@
</span><span class="cx"> start();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-eslConnectionManager::~eslConnectionManager()
-{
- doDisconnect();
-}
-
</del><span class="cx"> void eslConnectionManager::doConnect(QString host, QString pass, QString port)
</span><span class="cx"> {
</span><span class="cx"> connection = new ESLconnection(host.toAscii(), port.toAscii(), pass.toAscii());
</span><span class="lines">@@ -24,7 +18,7 @@
</span><span class="cx">
</span><span class="cx"> void eslConnectionManager::doDisconnect()
</span><span class="cx"> {
</span><del>- delete connection;
</del><ins>+ connection->disconnect();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void eslConnectionManager::run()
</span><span class="lines">@@ -52,10 +46,5 @@
</span><span class="cx"> emit gotEvent(e);
</span><span class="cx"> }
</span><span class="cx"> }
</span><del>- else
- {
- doDisconnect();
- break;
- }
</del><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="freeswitchtrunkcontribjmesquitafsguiesl_connectionh"></a>
<div class="modfile"><h4>Modified: freeswitch/trunk/contrib/jmesquita/fsgui/esl_connection.h (14211 => 14212)</h4>
<pre class="diff"><span>
<span class="info">--- freeswitch/trunk/contrib/jmesquita/fsgui/esl_connection.h 2009-07-13 04:29:55 UTC (rev 14211)
+++ freeswitch/trunk/contrib/jmesquita/fsgui/esl_connection.h 2009-07-13 06:01:22 UTC (rev 14212)
</span><span class="lines">@@ -13,7 +13,6 @@
</span><span class="cx"> Q_DISABLE_COPY(eslConnectionManager)
</span><span class="cx"> public:
</span><span class="cx"> eslConnectionManager();
</span><del>- virtual ~eslConnectionManager();
</del><span class="cx"> eslConnectionManager(QString,QString,QString);
</span><span class="cx"> void doConnect(QString, QString, QString);
</span><span class="cx"> void doDisconnect();
</span></span></pre></div>
<a id="freeswitchtrunkcontribjmesquitafsguifs_guicpp"></a>
<div class="modfile"><h4>Modified: freeswitch/trunk/contrib/jmesquita/fsgui/fs_gui.cpp (14211 => 14212)</h4>
<pre class="diff"><span>
<span class="info">--- freeswitch/trunk/contrib/jmesquita/fsgui/fs_gui.cpp 2009-07-13 04:29:55 UTC (rev 14211)
+++ freeswitch/trunk/contrib/jmesquita/fsgui/fs_gui.cpp 2009-07-13 06:01:22 UTC (rev 14212)
</span><span class="lines">@@ -13,12 +13,12 @@
</span><span class="cx"> // Set the default status bar message
</span><span class="cx"> m_ui->statusBar->showMessage(tr("Ready"));
</span><span class="cx">
</span><del>- connect(m_ui->actionConnect, SIGNAL(triggered())
- , serverDialog, SLOT(show()));
</del><ins>+ connect(m_ui->actionConnect, SIGNAL(triggered()),
+ serverDialog, SLOT(show()));
</ins><span class="cx"> connect(serverDialog, SIGNAL(doConnect(QString,QString,QString)),
</span><span class="cx"> this, SLOT(newConnectionFromDialog(QString,QString,QString)));
</span><ins>+}
</ins><span class="cx">
</span><del>- }
</del><span class="cx"> Cfsgui::~Cfsgui()
</span><span class="cx"> {
</span><span class="cx"> delete m_ui;
</span><span class="lines">@@ -30,15 +30,24 @@
</span><span class="cx"> m_ui->textConsole->append(text);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void Cfsgui::getDisconnectedSlot()
+{
+ delete eslConnection;
+}
+
</ins><span class="cx"> void Cfsgui::gotConnectedSlot()
</span><span class="cx"> {
</span><span class="cx"> m_ui->statusBar->showMessage("Connected");
</span><span class="cx"> appendConsoleText("Conneted!");
</span><ins>+ m_ui->actionConnect->setDisabled(true);
+ m_ui->actionDisconnect->setEnabled(true);
</ins><span class="cx"> }
</span><span class="cx"> void Cfsgui::gotDisconnectedSlot()
</span><span class="cx"> {
</span><span class="cx"> appendConsoleText("Disconnected!");
</span><span class="cx"> m_ui->textConsole->append("Conneted!");
</span><ins>+ m_ui->actionConnect->setEnabled(true);
+ m_ui->actionDisconnect->setDisabled(true);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Cfsgui::gotEventSlot(ESLevent * event)
</span><span class="lines">@@ -88,4 +97,7 @@
</span><span class="cx"> this, SLOT(gotDisconnectedSlot(void)));
</span><span class="cx"> connect(eslConnection, SIGNAL(gotEvent(ESLevent*)),
</span><span class="cx"> this, SLOT(gotEventSlot(ESLevent*)));
</span><ins>+ /* Connect the disconnect menu */
+ connect(m_ui->actionDisconnect, SIGNAL(triggered()),
+ this, SLOT(getDisconnectedSlot()));
</ins><span class="cx"> }
</span></span></pre></div>
<a id="freeswitchtrunkcontribjmesquitafsguifs_guih"></a>
<div class="modfile"><h4>Modified: freeswitch/trunk/contrib/jmesquita/fsgui/fs_gui.h (14211 => 14212)</h4>
<pre class="diff"><span>
<span class="info">--- freeswitch/trunk/contrib/jmesquita/fsgui/fs_gui.h 2009-07-13 04:29:55 UTC (rev 14211)
+++ freeswitch/trunk/contrib/jmesquita/fsgui/fs_gui.h 2009-07-13 06:01:22 UTC (rev 14212)
</span><span class="lines">@@ -28,6 +28,7 @@
</span><span class="cx"> void gotConnectedSlot();
</span><span class="cx"> void gotDisconnectedSlot();
</span><span class="cx"> void gotEventSlot(ESLevent *);
</span><ins>+ void getDisconnectedSlot();
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> Ui::Cfsgui *m_ui;
</span></span></pre></div>
<a id="freeswitchtrunkcontribjmesquitafsguifs_guiui"></a>
<div class="modfile"><h4>Modified: freeswitch/trunk/contrib/jmesquita/fsgui/fs_gui.ui (14211 => 14212)</h4>
<pre class="diff"><span>
<span class="info">--- freeswitch/trunk/contrib/jmesquita/fsgui/fs_gui.ui 2009-07-13 04:29:55 UTC (rev 14211)
+++ freeswitch/trunk/contrib/jmesquita/fsgui/fs_gui.ui 2009-07-13 06:01:22 UTC (rev 14212)
</span><span class="lines">@@ -58,7 +58,7 @@
</span><span class="cx"> <x>0</x>
</span><span class="cx"> <y>0</y>
</span><span class="cx"> <width>600</width>
</span><del>- <height>26</height>
</del><ins>+ <height>22</height>
</ins><span class="cx"> </rect>
</span><span class="cx"> </property>
</span><span class="cx"> <widget class="QMenu" name="menuFile">
</span><span class="lines">@@ -66,6 +66,7 @@
</span><span class="cx"> <string>&amp;File</string>
</span><span class="cx"> </property>
</span><span class="cx"> <addaction name="actionConnect"/>
</span><ins>+ <addaction name="actionDisconnect"/>
</ins><span class="cx"> <addaction name="separator"/>
</span><span class="cx"> <addaction name="actionQuit"/>
</span><span class="cx"> </widget>
</span><span class="lines">@@ -101,6 +102,17 @@
</span><span class="cx"> <string>Ctrl+C</string>
</span><span class="cx"> </property>
</span><span class="cx"> </action>
</span><ins>+ <action name="actionDisconnect">
+ <property name="enabled">
+ <bool>false</bool>
+ </property>
+ <property name="text">
+ <string>&amp;Disconnect</string>
+ </property>
+ <property name="shortcut">
+ <string>Ctrl+D</string>
+ </property>
+ </action>
</ins><span class="cx"> </widget>
</span><span class="cx"> <layoutdefault spacing="6" margin="11"/>
</span><span class="cx"> <tabstops>
</span></span></pre>
</div>
</div>
<div id="footer">See you at ClueCon</div>
</body>
</html>