[Freeswitch-svn] [commit] r13113 - in freeswitch/trunk/src: include mod/applications/mod_limit

[FreeSWITCH SVN]

Author: anthm
Date: Wed Apr 22 10:02:32 2009
New Revision: 13113

Log:
MODAPP-264 prevent multiple bindings of the same event_hooks to make code simpler in mod_limit

Modified:
   freeswitch/trunk/src/include/switch_core_event_hook.h
   freeswitch/trunk/src/mod/applications/mod_limit/mod_limit.c

Modified: freeswitch/trunk/src/include/switch_core_event_hook.h
==============================================================================
--- freeswitch/trunk/src/include/switch_core_event_hook.h	(original)
+++ freeswitch/trunk/src/include/switch_core_event_hook.h	Wed Apr 22 10:02:32 2009
@@ -183,12 +183,12 @@
 		assert(_NAME != NULL);											\
 		for (ptr = session->event_hooks._NAME; ptr && ptr->next; ptr = ptr->next) \
 			if (ptr->_NAME == _NAME) return SWITCH_STATUS_FALSE;		\
+		if (ptr && ptr->_NAME == _NAME) return SWITCH_STATUS_FALSE;		\
 		if ((hook = switch_core_session_alloc(session, sizeof(*hook))) != 0) { \
 			hook->_NAME = _NAME ;										\
 			if (! session->event_hooks._NAME ) {						\
 				session->event_hooks._NAME = hook;						\
 			} else {													\
-				for (ptr = session->event_hooks._NAME; ptr && ptr->next; ptr = ptr->next); \
 				ptr->next = hook;										\
 			}															\
 			return SWITCH_STATUS_SUCCESS;								\

Modified: freeswitch/trunk/src/mod/applications/mod_limit/mod_limit.c
==============================================================================
--- freeswitch/trunk/src/mod/applications/mod_limit/mod_limit.c	(original)
+++ freeswitch/trunk/src/mod/applications/mod_limit/mod_limit.c	Wed Apr 22 10:02:32 2009
@@ -67,7 +67,6 @@
 } limit_hash_item_t;
 
 typedef struct {
-	uint8_t have_state_handler;
 	switch_hash_t *hash;
 	} limit_hash_private_t;
 
@@ -377,7 +376,7 @@
 		
 		/* Remove handler */
 		switch_core_event_hook_remove_state_change(session, hash_state_handler);
-		pvt->have_state_handler = 0;
+
 		
 		switch_mutex_unlock(globals.limit_hash_mutex);
 	}
@@ -778,7 +777,6 @@
 	char buf[80] = "";
 	callback_t cbt = { 0 };
 	switch_channel_t *channel = switch_core_session_get_channel(session);
-	switch_bool_t new_channel = SWITCH_FALSE;
 
 	if (!switch_strlen_zero(data)) {
 		mydata = switch_core_session_strdup(session, data);
@@ -812,7 +810,6 @@
 	}
 
 	
-	new_channel = !switch_channel_get_variable(channel, "limit_realm");
 	switch_channel_set_variable(channel, "limit_realm", realm);
 	switch_channel_set_variable(channel, "limit_id", id);
 	switch_channel_set_variable(channel, "limit_max", argv[2]);
@@ -829,9 +826,9 @@
 		goto done;
 	}
 
-	if (new_channel) {
-		switch_core_event_hook_add_state_change(session, db_state_handler);
-	}
+	switch_core_event_hook_add_state_change(session, db_state_handler);
+	switch_core_event_hook_add_state_change(session, db_state_handler);
+
 	sql =
 		switch_mprintf("insert into limit_data (hostname, realm, id, uuid) values('%q','%q','%q','%q');", globals.hostname, realm, id,
 					   switch_core_session_get_uuid(session));
@@ -1025,11 +1022,9 @@
 		switch_channel_set_variable(channel, "limit_rate", srate);
 		switch_channel_set_variable(channel, switch_core_session_sprintf(session, "limit_rate_%s", hashkey), srate);
 	}
-	
-	if (!pvt->have_state_handler) {
-		switch_core_event_hook_add_state_change(session, hash_state_handler);
-		pvt->have_state_handler = 1;
-	}
+
+	switch_core_event_hook_add_state_change(session, hash_state_handler);
+
 	
 end:	
 	switch_mutex_unlock(globals.limit_hash_mutex);