<div dir="ltr"><span style="font-family:arial,sans-serif;font-size:13px">William,</span><br><div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:13px">Added one more section with how to update the pull request.</span></div>
<div><font face="arial, sans-serif"><br></font></div><div><font face="arial, sans-serif"><a href="https://confluence.freeswitch.org/display/FREESWITCH/Pull+Requests#PullRequests-UpdatingPullRequestwithnewcode">https://confluence.freeswitch.org/display/FREESWITCH/Pull+Requests#PullRequests-UpdatingPullRequestwithnewcode</a></font><br>
</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2014-08-29 12:27 GMT-03:00 William King <span dir="ltr"><<a href="mailto:wking@freeswitch.org" target="_blank">wking@freeswitch.org</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Looks great. Not sure how best to display this information, but each<br>
pull request tracks the branch from the forked repo. So if they update<br>
the branch, the pull request is automatically updated with the new<br>
commits. This means the person who is contributing code needs to have a<br>
separate branch for each pull request, and if a developer asks for a<br>
change, then the contributor needs to make the change in the branch, and<br>
push the new change.<br>
<br>
William King<br>
<a href="mailto:wking@freeswitch.org">wking@freeswitch.org</a><br>
FreeSWITCH Solutions, LLC<br>
PO BOX 2531<br>
Brookfield, WI 53008-2531<br>
Twitter: @FreeSWITCH , @quentusrex<br>
<a href="http://www.freeswitchbook.com" target="_blank">http://www.freeswitchbook.com</a><br>
<a href="http://www.freeswitchcookbook.com" target="_blank">http://www.freeswitchcookbook.com</a><br>
<br>
T: <a href="tel:%2B1.213.286.0416" value="+12132860416">+1.213.286.0416</a><br>
Skype:quentusrex<br>
<div class=""><br>
On 08/29/2014 07:43 AM, Ítalo Rossi wrote:<br>
> Here is the first version of the tutorial:<br>
><br>
> <a href="https://confluence.freeswitch.org/display/FREESWITCH/Pull+Requests" target="_blank">https://confluence.freeswitch.org/display/FREESWITCH/Pull+Requests</a><br>
><br>
> It's in Community -> Contributing Code -> Pull Requests.<br>
><br>
> English is not my first language, so maybe there are some gramatical<br>
> issues that need to be fixed #).<br>
><br>
><br>
> 2014-08-28 23:35 GMT-03:00 Ítalo Rossi <<a href="mailto:italorossib@gmail.com">italorossib@gmail.com</a><br>
</div>> <mailto:<a href="mailto:italorossib@gmail.com">italorossib@gmail.com</a>>>:<br>
<div><div class="h5">><br>
> Hi Ken,<br>
><br>
> Sure, I can do this tomorrow.<br>
><br>
> I think it's a good idea to put some screenshots, it helps to<br>
> understand whole process.<br>
><br>
> Hey guys, can one of you help me out with a little process doc?<br>
><br>
> We are trying to encourage people to use Pull Requests for Patches<br>
> and there seems to be a little confusion on how to do this.<br>
><br>
> Can someone write up this process nicely and post it on Confluence?<br>
><br>
> Here’s the steps<br>
><br>
> Login in to Stash<br>
> Go to Repo you want to add a patch to<br>
> Click the Fork Button.<br>
> In the PopUp, name your fork (it will default to FreeSWITCH, but you<br>
> may want to name it something more descriptive. Example<br>
> freeswitch-FS-1234 where FS-1234 is the name of a jira you are<br>
> addressing)<br>
> This will bring you to your fork repo.<br>
> Go to the “Settings” link on the menu bar, go to “Repository” link<br>
> under permissions on the left verticle menu<br>
> Check the enable box under Public Access.<br>
> Click Save<br>
><br>
> Clone this repo, commit your patches, and push this repo back to<br>
> stash. (standard GIT clone, commit, push workflow)<br>
><br>
> Return to Stash, Go to the Main FreeSWITCH Repo, and click “Pull<br>
> Request” Button Upper right<br>
> In the box on upper left, select your fork repo and branch that<br>
> contains the new commits.<br>
> Make sure that the FreeSWITCH/freeswitch repo is selected in the<br>
> upper right box.<br>
><br>
> Edit the Title (it will default to the branch name)<br>
> Edit the Description (if there is a matching Jira Please Reference<br>
> the Jira Ticket ID at the top of the description. The description<br>
> will auto populate with commit messages from commits on the branch<br>
> not already in FreeSWITCH master repo)<br>
><br>
> Click Create Pull Request.<br>
><br>
> If you have not received feedback on your Pull Request by the<br>
> regular Thursday Bug Hunt/Patch Review conference call, Call in to<br>
> the bridge at 2PM US Central Time (1900 GMT) and ask to have your<br>
> patch reviewed.<br>
><br>
> Documenter, Please reference the Confluence page for how to join the<br>
> conf calls.<br>
><br>
><br>
> Thanks<br>
> K<br>
><br>
><br>
><br>
><br>
><br>
><br>
><br>
> --<br>
> Ken<br>
</div></div>> _<a href="http://www.FreeSWITCH.org" target="_blank">http://www.FreeSWITCH.org</a><br>
> <a href="http://www.ClueCon.com" target="_blank">http://www.ClueCon.com</a><br>
> <a href="http://www.OSTAG.org" target="_blank">http://www.OSTAG.org</a><br>
> _<a href="http://irc.freenode.net" target="_blank">irc.freenode.net</a> <<a href="http://irc.freenode.net" target="_blank">http://irc.freenode.net</a>> #freeswitch<br>
<div class="">> Twitter: @FreeSWITCH<br>
><br>
><br>
> _______________________________________________<br>
> Freeswitch-docs mailing list<br>
> <a href="mailto:Freeswitch-docs@lists.freeswitch.org">Freeswitch-docs@lists.freeswitch.org</a><br>
</div>> <mailto:<a href="mailto:Freeswitch-docs@lists.freeswitch.org">Freeswitch-docs@lists.freeswitch.org</a>><br>
<div class="HOEnZb"><div class="h5">> <a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-docs" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-docs</a><br>
><br>
><br>
><br>
><br>
> --<br>
> Ítalo Rossi<br>
><br>
><br>
> _______________________________________________<br>
> Freeswitch-docs mailing list<br>
> <a href="mailto:Freeswitch-docs@lists.freeswitch.org">Freeswitch-docs@lists.freeswitch.org</a><br>
> <a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-docs" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-docs</a><br>
><br>
<br>
</div></div><br>_______________________________________________<br>
Freeswitch-docs mailing list<br>
<a href="mailto:Freeswitch-docs@lists.freeswitch.org">Freeswitch-docs@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-docs" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-docs</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Ítalo Rossi<br></div>
</div>