[Freeswitch-docs] Assistance from the docs team

Michael Jerris mike at jerris.com
Fri Aug 29 21:06:23 MSD 2014


Also needs a note about the pull request name should include the jira that the pull request is for

On Aug 29, 2014, at 11:27 AM, William King <wking at freeswitch.org> wrote:

> Looks great. Not sure how best to display this information, but each
> pull request tracks the branch from the forked repo. So if they update
> the branch, the pull request is automatically updated with the new
> commits. This means the person who is contributing code needs to have a
> separate branch for each pull request, and if a developer asks for a
> change, then the contributor needs to make the change in the branch, and
> push the new change.
> 
> William King
> wking at freeswitch.org
> FreeSWITCH Solutions, LLC
> PO BOX 2531
> Brookfield, WI 53008-2531
> Twitter: @FreeSWITCH , @quentusrex
> http://www.freeswitchbook.com
> http://www.freeswitchcookbook.com
> 
> T: +1.213.286.0416
> Skype:quentusrex
> 
> On 08/29/2014 07:43 AM, Ítalo Rossi wrote:
>> Here is the first version of the tutorial:
>> 
>> https://confluence.freeswitch.org/display/FREESWITCH/Pull+Requests
>> 
>> It's in Community -> Contributing Code -> Pull Requests.
>> 
>> English is not my first language, so maybe there are some gramatical
>> issues that need to be fixed #).
>> 
>> 
>> 2014-08-28 23:35 GMT-03:00 Ítalo Rossi <italorossib at gmail.com
>> <mailto:italorossib at gmail.com>>:
>> 
>>    Hi Ken,
>> 
>>    Sure, I can do this tomorrow.
>> 
>>    I think it's a good idea to put some screenshots, it helps to
>>    understand whole process.
>> 
>>    Hey guys, can one of you help me out with a little process doc?
>> 
>>    We are trying to encourage people to use Pull Requests for Patches
>>    and there seems to be a little confusion on how to do this.
>> 
>>    Can someone write up this process nicely and post it on Confluence?
>> 
>>    Here’s the steps
>> 
>>    Login in to Stash
>>    Go to Repo you want to add a patch to
>>    Click the Fork Button.
>>    In the PopUp, name your fork (it will default to FreeSWITCH, but you
>>    may want to name it something more descriptive. Example
>>    freeswitch-FS-1234   where FS-1234 is the name of a jira you are
>>    addressing)
>>    This will bring you to your fork repo.
>>    Go to the “Settings” link on the menu bar, go to “Repository” link
>>    under permissions on the left verticle menu
>>    Check the enable box under Public Access.
>>    Click Save
>> 
>>    Clone this repo, commit your patches, and push this repo back to
>>    stash. (standard GIT clone, commit, push workflow)
>> 
>>    Return to Stash, Go to the Main FreeSWITCH Repo, and click “Pull
>>    Request” Button Upper right
>>    In the box on upper left, select your fork repo and branch that
>>    contains the new commits.
>>    Make sure that the FreeSWITCH/freeswitch repo is selected in the
>>    upper right box.
>> 
>>    Edit the Title (it will default to the branch name)
>>    Edit the Description (if there is a matching Jira Please Reference
>>    the Jira Ticket ID at the top of the description. The description
>>    will auto populate with commit messages from commits on the branch
>>    not already in FreeSWITCH master repo)
>> 
>>    Click Create Pull Request.
>> 
>>    If you have not received feedback on your Pull Request by the
>>    regular Thursday Bug Hunt/Patch Review conference call, Call in to
>>    the bridge at 2PM US Central Time (1900 GMT) and ask to have your
>>    patch reviewed.
>> 
>>    Documenter, Please reference the Confluence page for how to join the
>>    conf calls.
>> 
>> 
>>    Thanks
>>    K
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>>    -- 
>>    Ken
>>    _http://www.FreeSWITCH.org
>>    http://www.ClueCon.com
>>    http://www.OSTAG.org
>>    _irc.freenode.net <http://irc.freenode.net> #freeswitch
>>    Twitter: @FreeSWITCH
>> 
>> 
>>    _______________________________________________
>>    Freeswitch-docs mailing list
>>    Freeswitch-docs at lists.freeswitch.org
>>    <mailto:Freeswitch-docs at lists.freeswitch.org>
>>    http://lists.freeswitch.org/mailman/listinfo/freeswitch-docs
>> 
>> 
>> 
>> 
>> -- 
>> Ítalo Rossi
>> 
>> 
>> _______________________________________________
>> Freeswitch-docs mailing list
>> Freeswitch-docs at lists.freeswitch.org
>> http://lists.freeswitch.org/mailman/listinfo/freeswitch-docs
>> 
> 
> _______________________________________________
> Freeswitch-docs mailing list
> Freeswitch-docs at lists.freeswitch.org
> http://lists.freeswitch.org/mailman/listinfo/freeswitch-docs

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.freeswitch.org/pipermail/freeswitch-docs/attachments/20140829/135a4aa7/attachment.html 


Join us at ClueCon 2014 Aug 4-7, 2014
More information about the Freeswitch-docs mailing list