<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=windows-1250">
<style>
<!--
@font-face
        {font-family:Helvetica}
@font-face
        {font-family:"Cambria Math"}
@font-face
        {font-family:Calibri}
@font-face
        {font-family:Tahoma}
@font-face
        {font-family:Consolas}
p.MsoNormal, li.MsoNormal, div.MsoNormal
        {margin:0in;
        margin-bottom:.0001pt;
        font-size:12.0pt;
        font-family:"Times New Roman",serif}
a:link, span.MsoHyperlink
        {color:blue;
        text-decoration:underline}
a:visited, span.MsoHyperlinkFollowed
        {color:purple;
        text-decoration:underline}
pre
        {margin:0in;
        margin-bottom:.0001pt;
        font-size:10.0pt;
        font-family:"Courier New"}
p.msonormal0, li.msonormal0, div.msonormal0
        {margin-right:0in;
        margin-left:0in;
        font-size:12.0pt;
        font-family:"Times New Roman",serif}
span.HTMLPreformattedChar
        {font-family:Consolas}
span.EmailStyle20
        {font-family:"Calibri",sans-serif;
        color:windowtext}
.MsoChpDefault
        {font-size:10.0pt}
@page WordSection1
        {margin:1.0in 1.0in 1.0in 1.0in}
-->
</style><style type="text/css" id="owaParaStyle"></style>
</head>
<body lang="EN-US" link="blue" vlink="purple" fpstyle="1" ocsi="0">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">Thanks!<br>
<br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div id="divRpF153041" style="direction: ltr;"><font face="Tahoma" size="2" color="#000000"><b>Od:</b> freeswitch-dev-bounces@lists.freeswitch.org [freeswitch-dev-bounces@lists.freeswitch.org] u ime korisnika Ken Rice [krice@freeswitch.org]<br>
<b>Poslato:</b> 30. avgust 2016 19:34<br>
<b>Za:</b> freeswitch-dev@lists.freeswitch.org<br>
<b>Tema:</b> Re: [Freeswitch-dev] Static analysis tool Cppcheck discovered many errors in FreeSWITCH code<br>
</font><br>
</div>
<div></div>
<div>
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:&quot;Calibri&quot;,sans-serif">Easiest way is via gitů see
<a href="https://freeswitch.org/stash/projects/FS/repos/freeswitch/browse" target="_blank">
https://freeswitch.org/stash/projects/FS/repos/freeswitch/browse</a>&nbsp; (we use stash which is bitbucket or sorta like github)</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; font-family:&quot;Calibri&quot;,sans-serif">&nbsp;</span></p>
<div>
<div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt; font-family:&quot;Calibri&quot;,sans-serif">From:</span></b><span style="font-size:11.0pt; font-family:&quot;Calibri&quot;,sans-serif"> freeswitch-dev-bounces@lists.freeswitch.org [mailto:freeswitch-dev-bounces@lists.freeswitch.org]
<b>On Behalf Of </b>Vladimir Mancic<br>
<b>Sent:</b> Tuesday, August 30, 2016 12:19 PM<br>
<b>To:</b> freeswitch-dev@lists.freeswitch.org<br>
<b>Subject:</b> Re: [Freeswitch-dev] Static analysis tool Cppcheck discovered many errors in FreeSWITCH code</span></p>
</div>
</div>
<p class="MsoNormal">&nbsp;</p>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">Thank you.
</span></p>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">&nbsp;</span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">And how to get the latest master branch?</span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">&nbsp;</span></p>
</div>
<div>
<pre style="margin-top:7.5pt; line-height:15.0pt; background:white"><span style="font-size:10.5pt; font-family:&quot;Tahoma&quot;,sans-serif; color:#333333">Vladimir</span><span style="font-size:10.5pt; color:#333333"></span></pre>
</div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">&nbsp;</span></p>
<div>
<div class="MsoNormal" align="center" style="text-align:center"><span style="color:black">
<hr size="2" width="100%" align="center">
</span></div>
<div id="divRpF210911">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">Od:</span></b><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">
<a href="mailto:freeswitch-dev-bounces@lists.freeswitch.org" target="_blank">freeswitch-dev-bounces@lists.freeswitch.org</a> [freeswitch-dev-bounces@lists.freeswitch.org] u ime korisnika Michael Jerris [mike@jerris.com]<br>
<b>Poslato:</b> 30. avgust 2016 16:05<br>
<b>Za:</b> <a href="mailto:freeswitch-dev@lists.freeswitch.org" target="_blank">freeswitch-dev@lists.freeswitch.org</a><br>
<b>Tema:</b> Re: [Freeswitch-dev] Static analysis tool Cppcheck discovered many errors in FreeSWITCH code</span><span style="color:black"></span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black">The correct way to do this would be to run this on the latest master branch of freeswitch and file and potential issues as security issues in Jira. &nbsp;Yes, many hundreds of issues have been fixed since 1.4 (1.4 is
 now eol) and we make use of static analysis tools. &nbsp;Static analysis tools in general have very high false positive rate, we do our best to address issues found with them, but they require much more than running a tool and getting a report. &nbsp;Every single one
 of those reports needs to be investigated, confirmed if its actually valid (typically 80%&#43; are not), reported.
</span></p>
<div>
<p class="MsoNormal"><span style="color:black">&nbsp;</span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black">&nbsp;</span></p>
<div>
<blockquote style="margin-top:5.0pt; margin-bottom:5.0pt">
<div>
<p class="MsoNormal"><span style="color:black">On Aug 30, 2016, at 9:07 AM, Vladimir Mancic &lt;<a href="mailto:vmancic@ooma.com" target="_blank">vmancic@ooma.com</a>&gt; wrote:</span></p>
</div>
<p class="MsoNormal"><span style="color:black">&nbsp;</span></p>
<div>
<div>
<p class="MsoNormal" style=""><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">Hi,</span></p>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">&nbsp;</span></p>
</div>
<p class="MsoNormal" style=""><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">Static analysis tool Cppcheck discovered many errors in FreeSWITCH v1.4 code (memory leaks, resource leaks, double frees,...):</span></p>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">&nbsp;</span></p>
</div>
<p class="MsoNormal" style=""><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">- memleak (76 occurances)</span></p>
<p class="MsoNormal" style=""><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">- memleakOnRealloc (12 occurances)</span></p>
<p class="MsoNormal" style=""><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">- resourceLeak (21 occurances)</span></p>
<p class="MsoNormal" style=""><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">- doubleFree (more than 100 occurances)</span></p>
<p class="MsoNormal" style=""><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">&nbsp;</span></p>
<p class="MsoNormal" style=""><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">Is this known to the&nbsp;FreeSWITCH&nbsp;community, and has there been any work on it&nbsp;in more recent versions of&nbsp;FreeSWITCH?</span></p>
<p class="MsoNormal" style=""><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">&nbsp;</span></p>
<p class="MsoNormal" style=""><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">&nbsp;</span></p>
<p class="MsoNormal" style=""><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">Thanks,</span></p>
<p class="MsoNormal" style=""><span style="font-size:10.0pt; font-family:&quot;Tahoma&quot;,sans-serif; color:black">Vladimir</span></p>
</div>
<p class="MsoNormal"><span style="color:black">&lt;FreeSwitch-Cppcheck-Results.xml&gt;</span><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif; color:black">_________________________________________________________________________<br>
Professional FreeSWITCH Consulting Services:<br>
</span><span style="color:black"><a href="mailto:consulting@freeswitch.org" target="_blank"><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif">consulting@freeswitch.org</span></a></span><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif; color:black"><br>
</span><span style="color:black"><a href="http://www.freeswitchsolutions.com/" target="_blank"><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif">http://www.freeswitchsolutions.com</span></a></span><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif; color:black"><br>
<br>
Official FreeSWITCH Sites<br>
</span><span style="color:black"><a href="http://www.freeswitch.org/" target="_blank"><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif">http://www.freeswitch.org</span></a></span><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif; color:black"><br>
</span><span style="color:black"><a href="http://wiki.freeswitch.org/" target="_blank"><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif">http://wiki.freeswitch.org</span></a></span><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif; color:black"><br>
</span><span style="color:black"><a href="http://www.cluecon.com/" target="_blank"><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif">http://www.cluecon.com</span></a></span><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif; color:black"><br>
<br>
FreeSWITCH-dev mailing list<br>
</span><span style="color:black"><a href="mailto:FreeSWITCH-dev@lists.freeswitch.org" target="_blank"><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif">FreeSWITCH-dev@lists.freeswitch.org</span></a></span><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif; color:black"><br>
</span><span style="color:black"><a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev" target="_blank"><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif">http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev</span></a></span><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif; color:black"><br>
UNSUBSCRIBE:http://</span><span style="color:black"><a href="http://lists.freeswitch.org/mailman/options/freeswitch-dev" target="_blank"><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif">lists.freeswitch.org/mailman/options/freeswitch-dev</span></a></span><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif; color:black"><br>
</span><span style="color:black"><a href="http://www.freeswitch.org/" target="_blank"><span style="font-size:9.0pt; font-family:&quot;Helvetica&quot;,sans-serif">http://www.freeswitch.org</span></a></span></p>
</div>
</blockquote>
</div>
<p class="MsoNormal"><span style="color:black">&nbsp;</span></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>