<style>blockquote {padding-left: 1ex; margin: 0px 0px 0px 0.8ex; border-left: #cccccc 1px solid;} p {margin: 0px;padding: 0px;} </style>
<p>I'd like ask you think this patch could be accepted soon, or maybe you want me to modify it somehow. I prepared another one which adds another member flag, so it depends on pause/resume...</p>
<p> </p>
<p>Mariusz</p>
<p> </p>
<p>Dnia 12-03-2012 o godz. 22:14 Mariusz Czulada napisał(a):</p>
<blockquote><!-- blockquote {padding-left: 1ex; margin: 0px 0px 0px 0.8ex; border-left: #cccccc 1px solid;} p {margin: 0px;padding: 0px;} -->
<p>Hi,</p>
<p> </p>
<p>As I said, I put the patch to JIRA (FS-3840). I wonder if it's acceptable or I should change something in it.</p>
<p> </p>
<p>Regards,</p>
<p> </p>
<p>Mariusz</p>
<p> </p>
<p>Dnia 20-12-2011 o godz. 23:47 Anthony Minessale napisał(a):</p>
<blockquote>I'm ok with that idea as long as its done cleanly.
<div><br /><br />
<div class="gmail_quote">2011/12/20 Mariusz Czulada <span dir="ltr"><<a href="mailto:manieq@wp.eu">manieq@wp.eu</a>></span><br />
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<p>I see. Here is another approach.</p>
<p> </p>
<p>There is one more thing before puting it on Jira. Now we have 5 conference functions related to recoding (including new ones):</p>
<p> record <filename><br /> chkrecord <confname><br /> norecord <[filename|all]><br /> pause <filename><br /> resume <filename></p>
<p>All these require just one parameter - file name. What do you think about adding alternative syntax:</p>
<p> </p>
<p> record start <filename><br /> record check <confname><br /> record stop <[filename|all]><br /> record pause <filename><br /> record resume <filename></p>
<p> </p>
<p>I said "alternative" because it will require 2 params (action + file name) so both ways can easily coexist (ordinary record needs only one param) but the second one IMHO is better because of grouping recording functions together.</p>
<p> </p>
<p>Regards,</p>
<p>Mariusz</p>
<p> </p>
<p>Dnia 20-12-2011 o godz. 20:55 Anthony Minessale napisał(a):</p>
<div>
<div class="h5">
<blockquote>member->fnode is for playing files in the confrence not recording.
<div><br /></div>
<div>Instead of passing the flag to the fh, maybe try just testing the flag on each write to the file in mod conference and skip doing it while the pause flag is set....</div>
<div><br /></div>
<div><br /><br />
<div class="gmail_quote">2011/12/20 Mariusz Czulada <span dir="ltr"><<a href="mailto:manieq@wp.eu" target="_blank">manieq@wp.eu</a>></span><br />
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br /> <br /> I try to prepare a patch which allows to pause/resume a given recording. I'm in the middle of the road: pause is working, by resume - not :(. I'd like to ask for your help in finding a problem. I'm not sure if I handle member and file flags in the thread sub correctly.<br /> <br /> BTW. I lost some time playing with member-fnode until found fh in conference_record_thread_run
is a proper handler. What is the conference_file_node_t member->fnode used for, if not for handling a recording file?<br /> <br /> Regards,<br /> <span style="color:#888888"><br /> Mariusz<br /> </span><br />_________________________________________________________________________<br /> Professional FreeSWITCH Consulting Services:<br /> <a href="mailto:consulting@freeswitch.org" target="_blank">consulting@freeswitch.org</a><br /> <a href="http://www.freeswitchsolutions.com"
target="_blank">http://www.freeswitchsolutions.com</a><br /> <br /> FreeSWITCH-powered IP PBX: The CudaTel Communication Server<br /> <a href="http://www.cudatel.com" target="_blank">http://www.cudatel.com</a><br /> <br /> Official FreeSWITCH Sites<br /> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br /> <a href="http://wiki.freeswitch.org" target="_blank">http://wiki.freeswitch.org</a><br /> <a href="http://www.cluecon.com"
target="_blank">http://www.cluecon.com</a><br /> <br /> FreeSWITCH-dev mailing list<br /> <a href="mailto:FreeSWITCH-dev@lists.freeswitch.org" target="_blank">FreeSWITCH-dev@lists.freeswitch.org</a><br /> <a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev</a><br /> UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-dev"
target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-dev</a><br /> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br /> <br /></blockquote>
</div>
<br /><br />
<div><br /></div>
-- <br />Anthony Minessale II<br /><br />FreeSWITCH <a href="http://www.freeswitch.org/" target="_blank">http://www.freeswitch.org/</a><br />ClueCon <a href="http://www.cluecon.com/" target="_blank">http://www.cluecon.com/</a><br /> Twitter: <a href="http://twitter.com/FreeSWITCH_wire" target="_blank">http://twitter.com/FreeSWITCH_wire</a><br /><br />AIM: anthm<br /><a href="mailto:MSN%3Aanthony_minessale@hotmail.com" target="_blank">MSN:anthony_minessale@hotmail.com</a><br /> GTALK/JABBER/<a
href="mailto:PAYPAL%3Aanthony.minessale@gmail.com" target="_blank">PAYPAL:anthony.minessale@gmail.com</a><br /> IRC: <a href="http://irc.freenode.net" target="_blank">irc.freenode.net</a> #freeswitch<br /><br /> FreeSWITCH Developer Conference<br /><a href="mailto:sip%3A888@conference.freeswitch.org" target="_blank">sip:888@conference.freeswitch.org</a><br /><a href="mailto:googletalk%3Aconf%2B888@conference.freeswitch.org" target="_blank">googletalk:conf+888@conference.freeswitch.org</a><br
/> pstn:<a href="tel:%2B19193869900" target="_blank">+19193869900</a><br /></div>
</blockquote>
<p> </p>
<br /></div>
</div>
<br />_________________________________________________________________________<br /> Professional FreeSWITCH Consulting Services:<br /> <a href="mailto:consulting@freeswitch.org">consulting@freeswitch.org</a><br /> <a href="http://www.freeswitchsolutions.com" target="_blank">http://www.freeswitchsolutions.com</a><br /> <br /> FreeSWITCH-powered IP PBX: The CudaTel Communication Server<br /> <a href="http://www.cudatel.com" target="_blank">http://www.cudatel.com</a><br /> <br /> Official
FreeSWITCH Sites<br /> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br /> <a href="http://wiki.freeswitch.org" target="_blank">http://wiki.freeswitch.org</a><br /> <a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a><br /> <br /> FreeSWITCH-dev mailing list<br /> <a href="mailto:FreeSWITCH-dev@lists.freeswitch.org">FreeSWITCH-dev@lists.freeswitch.org</a><br /> <a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev"
target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev</a><br /> UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-dev</a><br /> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br /> <br /></blockquote>
</div>
<br /><br />
<div><br /></div>
-- <br />Anthony Minessale II<br /><br />FreeSWITCH <a href="http://www.freeswitch.org/">http://www.freeswitch.org/</a><br />ClueCon <a href="http://www.cluecon.com/">http://www.cluecon.com/</a><br /> Twitter: <a href="http://twitter.com/FreeSWITCH_wire">http://twitter.com/FreeSWITCH_wire</a><br /><br />AIM: anthm<br /><a href="mailto:MSN%3Aanthony_minessale@hotmail.com">MSN:anthony_minessale@hotmail.com</a><br />GTALK/JABBER/<a
href="mailto:PAYPAL%3Aanthony.minessale@gmail.com">PAYPAL:anthony.minessale@gmail.com</a><br /> IRC: <a href="http://irc.freenode.net">irc.freenode.net</a> #freeswitch<br /><br />FreeSWITCH Developer Conference<br /><a href="mailto:sip%3A888@conference.freeswitch.org">sip:888@conference.freeswitch.org</a><br /><a href="mailto:googletalk%3Aconf%2B888@conference.freeswitch.org">googletalk:conf+888@conference.freeswitch.org</a><br /> pstn:+19193869900<br /></div>
</blockquote>
<p> </p>
<br /></blockquote>
<p><br /></p><br />