Thank you, I will do so in future.<br><br>Ted<br><br><div class="gmail_quote">On 8 May 2012 19:31, Anthony Minessale <span dir="ltr"><<a href="mailto:anthony.minessale@gmail.com" target="_blank">anthony.minessale@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">fixed but you should have reported it to <a href="http://jira.freeswitch.org" target="_blank">http://jira.freeswitch.org</a><br>
<div><div class="h5"><br>
<br>
<br>
On Tue, May 8, 2012 at 9:20 PM, Ken Rice <<a href="mailto:krice@freeswitch.org">krice@freeswitch.org</a>> wrote:<br>
> What platform is this on? You need to be specific when reporting these types<br>
> of errors....<br>
><br>
><br>
><br>
> On 5/8/12 4:49 PM, "Ted Walther" <<a href="mailto:tederific@gmail.com">tederific@gmail.com</a>> wrote:<br>
><br>
> Compiling mod_spandsp_modem.c ...<br>
> cc1: warnings being treated as errors<br>
> mod_spandsp_modem.c: In function 'modem_init':<br>
> mod_spandsp_modem.c:380: warning: ISO C90 forbids mixed declarations and<br>
> code<br>
> mod_spandsp_modem.c:398: error: invalid storage class for function<br>
> 'channel_on_init'<br>
> mod_spandsp_modem.c:399: error: invalid storage class for function<br>
> 'channel_on_hangup'<br>
> mod_spandsp_modem.c:400: error: invalid storage class for function<br>
> 'channel_on_destroy'<br>
> mod_spandsp_modem.c:401: error: invalid storage class for function<br>
> 'channel_on_routing'<br>
> mod_spandsp_modem.c:402: error: invalid storage class for function<br>
> 'channel_on_exchange_media'<br>
> mod_spandsp_modem.c:403: error: invalid storage class for function<br>
> 'channel_on_soft_execute'<br>
> mod_spandsp_modem.c:407: error: invalid storage class for function<br>
> 'channel_outgoing_channel'<br>
> mod_spandsp_modem.c:408: error: invalid storage class for function<br>
> 'channel_read_frame'<br>
> mod_spandsp_modem.c:409: error: invalid storage class for function<br>
> 'channel_write_frame'<br>
> mod_spandsp_modem.c:410: error: invalid storage class for function<br>
> 'channel_kill_channel'<br>
> mod_spandsp_modem.c:419: warning: ISO C forbids nested functions<br>
> mod_spandsp_modem.c:419: error: invalid storage class for function<br>
> 'channel_on_init'<br>
> mod_spandsp_modem.c: In function 'channel_on_init':<br>
> mod_spandsp_modem.c:445: warning: implicit declaration of function 'ioctl'<br>
> mod_spandsp_modem.c: In function 'modem_init':<br>
> mod_spandsp_modem.c:489: warning: ISO C forbids nested functions<br>
> mod_spandsp_modem.c:489: error: invalid storage class for function<br>
> 'channel_on_routing'<br>
> mod_spandsp_modem.c:503: warning: ISO C forbids nested functions<br>
> mod_spandsp_modem.c:503: error: invalid storage class for function<br>
> 'channel_on_execute'<br>
> mod_spandsp_modem.c:519: warning: ISO C forbids nested functions<br>
> mod_spandsp_modem.c:519: error: invalid storage class for function<br>
> 'channel_on_destroy'<br>
> mod_spandsp_modem.c:543: warning: ISO C forbids nested functions<br>
> mod_spandsp_modem.c:543: error: invalid storage class for function<br>
> 'channel_on_hangup'<br>
> mod_spandsp_modem.c:560: warning: ISO C forbids nested functions<br>
> mod_spandsp_modem.c:560: error: invalid storage class for function<br>
> 'channel_kill_channel'<br>
> mod_spandsp_modem.c:586: warning: ISO C forbids nested functions<br>
> mod_spandsp_modem.c:586: error: invalid storage class for function<br>
> 'channel_on_soft_execute'<br>
> mod_spandsp_modem.c:592: warning: ISO C forbids nested functions<br>
> mod_spandsp_modem.c:592: error: invalid storage class for function<br>
> 'channel_on_exchange_media'<br>
> mod_spandsp_modem.c:608: warning: ISO C forbids nested functions<br>
> mod_spandsp_modem.c:608: error: invalid storage class for function<br>
> 'channel_on_reset'<br>
><br>
> It looks to me like the error is here:<br>
><br>
> #if USE_OPENPTY<br>
> if (openpty(&modem->master, &modem->slave, NULL, NULL, NULL)) {<br>
><br>
> if (modem->master < 0) {<br>
> switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR,<br>
> "Fatal error: failed to initialize pty\n");<br>
> status = SWITCH_STATUS_FALSE;<br>
> goto end;<br>
> }<br>
><br>
> modem->stty = ttyname(modem->slave);<br>
> #else<br>
><br>
><br>
> I traced to the bottom of the function, and didn't see a matching close<br>
> brace. I believe it is the if(modem->master < 0){ statement that is missing<br>
> the closing } after the goto end; statement.<br>
><br>
> Can a more knowledgeable developer confirm that this is correct.<br>
><br>
> Ted<br>
><br>
> ________________________________<br>
> _________________________________________________________________________<br>
> Professional FreeSWITCH Consulting Services:<br>
> <a href="mailto:consulting@freeswitch.org">consulting@freeswitch.org</a><br>
> <a href="http://www.freeswitchsolutions.com" target="_blank">http://www.freeswitchsolutions.com</a><br>
><br>
> FreeSWITCH-powered IP PBX: The CudaTel Communication Server<br>
> <a href="http://www.cudatel.com" target="_blank">http://www.cudatel.com</a><br>
><br>
> Official FreeSWITCH Sites<br>
> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
> <a href="http://wiki.freeswitch.org" target="_blank">http://wiki.freeswitch.org</a><br>
> <a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a><br>
><br>
> FreeSWITCH-dev mailing list<br>
> <a href="mailto:FreeSWITCH-dev@lists.freeswitch.org">FreeSWITCH-dev@lists.freeswitch.org</a><br>
> <a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev</a><br>
> UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-dev</a><br>
> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
><br>
><br>
> _________________________________________________________________________<br>
> Professional FreeSWITCH Consulting Services:<br>
> <a href="mailto:consulting@freeswitch.org">consulting@freeswitch.org</a><br>
> <a href="http://www.freeswitchsolutions.com" target="_blank">http://www.freeswitchsolutions.com</a><br>
><br>
> FreeSWITCH-powered IP PBX: The CudaTel Communication Server<br>
> <a href="http://www.cudatel.com" target="_blank">http://www.cudatel.com</a><br>
><br>
> Official FreeSWITCH Sites<br>
> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
> <a href="http://wiki.freeswitch.org" target="_blank">http://wiki.freeswitch.org</a><br>
> <a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a><br>
><br>
> FreeSWITCH-dev mailing list<br>
> <a href="mailto:FreeSWITCH-dev@lists.freeswitch.org">FreeSWITCH-dev@lists.freeswitch.org</a><br>
> <a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev</a><br>
> UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-dev</a><br>
> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
><br>
<br>
<br>
<br>
</div></div>--<br>
Anthony Minessale II<br>
<br>
FreeSWITCH <a href="http://www.freeswitch.org/" target="_blank">http://www.freeswitch.org/</a><br>
ClueCon <a href="http://www.cluecon.com/" target="_blank">http://www.cluecon.com/</a><br>
Twitter: <a href="http://twitter.com/FreeSWITCH_wire" target="_blank">http://twitter.com/FreeSWITCH_wire</a><br>
<br>
AIM: anthm<br>
<a href="mailto:MSN%3Aanthony_minessale@hotmail.com">MSN:anthony_minessale@hotmail.com</a><br>
GTALK/JABBER/<a href="mailto:PAYPAL%3Aanthony.minessale@gmail.com">PAYPAL:anthony.minessale@gmail.com</a><br>
IRC: <a href="http://irc.freenode.net" target="_blank">irc.freenode.net</a> #freeswitch<br>
<br>
FreeSWITCH Developer Conference<br>
<a href="mailto:sip%3A888@conference.freeswitch.org">sip:888@conference.freeswitch.org</a><br>
<a href="mailto:googletalk%3Aconf%2B888@conference.freeswitch.org">googletalk:conf+888@conference.freeswitch.org</a><br>
pstn:<a href="tel:%2B19193869900" value="+19193869900">+19193869900</a><br>
<div class="HOEnZb"><div class="h5"><br>
_________________________________________________________________________<br>
Professional FreeSWITCH Consulting Services:<br>
<a href="mailto:consulting@freeswitch.org">consulting@freeswitch.org</a><br>
<a href="http://www.freeswitchsolutions.com" target="_blank">http://www.freeswitchsolutions.com</a><br>
<br>
FreeSWITCH-powered IP PBX: The CudaTel Communication Server<br>
<a href="http://www.cudatel.com" target="_blank">http://www.cudatel.com</a><br>
<br>
Official FreeSWITCH Sites<br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<a href="http://wiki.freeswitch.org" target="_blank">http://wiki.freeswitch.org</a><br>
<a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a><br>
<br>
FreeSWITCH-dev mailing list<br>
<a href="mailto:FreeSWITCH-dev@lists.freeswitch.org">FreeSWITCH-dev@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-dev</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
</div></div></blockquote></div><br>