<span style>My two cents:</span><div style><br></div><div style>As already stated by Ken Rice, trailing spaces are not a problem. And I personally had a bad experience in purely aesthetic code cleanups. It messes up the "blame" function of the VCS (git in this case), once the last modifications in the the altered lines will be assigned to whoever commited the cleanup.</div>
<div style><br></div><div style>--</div><div style>Rafael Vargas</div><div style><br></div><br><div class="gmail_quote">On Mon, Apr 9, 2012 at 09:24, Seven Du <span dir="ltr"><<a href="mailto:dujinfang@gmail.com">dujinfang@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>I also prefer small, controlled updates, however I can't do git push and jira would be a little pain ...</div><div>Ken mentioned there's nothing wrong with white spaces in another mail, I agree but still think it's a little pain to generate "clean" diff when there's many trailing spaces involved. And as I said doing this could affect all devs So I'd like to get their ideas, especially we have more branches than before it's means need more merge and possible there's conflicts...</div>
<div><br></div><div>7.</div><div><div class="h5"><div><br></div>
<p style="color:#a0a0a8">On Sunday, April 8, 2012 at 4:01 AM, Michael Collins wrote:</p>
</div></div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px">
<span><div><div><div class="h5"><div>/usr/src/freeswitch/src# grep -rc "\s\+$" * | grep -v ":0$"<br><br>1200+ files with trailing whitespace does seem a bit excessive, however I don't know how large a "problem" it really is. If you're going to do whitespace cleanup I recommend starting small, like with mod_rtmp.c. Run your whitespace cleanup script on just a few files, recompile them, verify that it's all good, then commit & push. I don't know about the other devs, but I would feel much more comfortable with small, controlled updates than a large sweep that does a lot of files.<br>
<br>Just my $0.02...<br><br>-MC<br><br><div>On Sat, Apr 7, 2012 at 8:49 AM, Seven Du <span dir="ltr"><<a href="mailto:dujinfang@gmail.com" target="_blank">dujinfang@gmail.com</a>></span> wrote:<br><blockquote type="cite">
<div>
<div>cat -t mod_rtmp.c | grep I</div><div>cat mod_rtmp.c | grep " $"</div><div><br></div><div>some editors insert tabs automatically when you press enter.</div><div><br></div>
<p style="color:#a0a0a8">On Saturday, April 7, 2012 at 12:26 PM, Michael Collins wrote:</p><blockquote type="cite"><div>
<span><div><div>can you show us an example of code w/ trailing whitespaces?<br>-MC<br></div></div></span></div></blockquote></div></blockquote><br></div>
</div></div></div><div class="im"><div><div>_________________________________________________________________________</div><div>Professional FreeSWITCH Consulting Services:</div><div><a href="mailto:consulting@freeswitch.org" target="_blank">consulting@freeswitch.org</a></div>
<div><a href="http://www.freeswitchsolutions.com" target="_blank">http://www.freeswitchsolutions.com</a></div><div><br></div><div>FreeSWITCH-powered IP PBX: The CudaTel Communication Server</div><div><a href="http://www.cudatel.com" target="_blank">http://www.cudatel.com</a></div>
<div><br></div><div>Official FreeSWITCH Sites</div><div><a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a></div><div><a href="http://wiki.freeswitch.org" target="_blank">http://wiki.freeswitch.org</a></div>
<div><a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a></div><div><br></div><div>FreeSWITCH-dev mailing list</div><div><a href="mailto:FreeSWITCH-dev@lists.freeswitch.org" target="_blank">FreeSWITCH-dev@lists.freeswitch.org</a></div>
<div><a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev</a></div><div>UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-dev</a></div>
<div><a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a></div></div></div></div></span>
</blockquote>
<div>
<br>
</div>
<br>_________________________________________________________________________<br>
Professional FreeSWITCH Consulting Services:<br>
<a href="mailto:consulting@freeswitch.org">consulting@freeswitch.org</a><br>
<a href="http://www.freeswitchsolutions.com" target="_blank">http://www.freeswitchsolutions.com</a><br>
<br>
FreeSWITCH-powered IP PBX: The CudaTel Communication Server<br>
<a href="http://www.cudatel.com" target="_blank">http://www.cudatel.com</a><br>
<br>
Official FreeSWITCH Sites<br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<a href="http://wiki.freeswitch.org" target="_blank">http://wiki.freeswitch.org</a><br>
<a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a><br>
<br>
FreeSWITCH-dev mailing list<br>
<a href="mailto:FreeSWITCH-dev@lists.freeswitch.org">FreeSWITCH-dev@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-dev</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<br></blockquote></div><br>