<div>I also prefer small, controlled updates, however I can't do git push and jira would be a little pain ...</div><div>Ken mentioned there's nothing wrong with white spaces in another mail, I agree but still think it's a little pain to generate "clean" diff when there's many trailing spaces involved. And as I said doing this could affect all devs So I'd like to get their ideas, especially we have more branches than before it's means need more merge and possible there's conflicts...</div><div><br></div><div>7.</div><div><br></div>
<p style="color: #A0A0A8;">On Sunday, April 8, 2012 at 4:01 AM, Michael Collins wrote:</p>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;">
<span><div><div>/usr/src/freeswitch/src# grep -rc "\s\+$" * | grep -v ":0$"<br><br>1200+ files with trailing whitespace does seem a bit excessive, however I don't know how large a "problem" it really is. If you're going to do whitespace cleanup I recommend starting small, like with mod_rtmp.c. Run your whitespace cleanup script on just a few files, recompile them, verify that it's all good, then commit & push. I don't know about the other devs, but I would feel much more comfortable with small, controlled updates than a large sweep that does a lot of files.<br>
<br>Just my $0.02...<br><br>-MC<br><br><div>On Sat, Apr 7, 2012 at 8:49 AM, Seven Du <span dir="ltr"><<a href="mailto:dujinfang@gmail.com">dujinfang@gmail.com</a>></span> wrote:<br><blockquote type="cite"><div>
<div>cat -t mod_rtmp.c | grep I</div><div>cat mod_rtmp.c | grep " $"</div><div><br></div><div>some editors insert tabs automatically when you press enter.</div><div><br></div>
<p style="color:#a0a0a8">On Saturday, April 7, 2012 at 12:26 PM, Michael Collins wrote:</p><blockquote type="cite"><div>
<span><div><div>can you show us an example of code w/ trailing whitespaces?<br>-MC<br></div></div></span></div></blockquote></div></blockquote><br></div>
</div><div><div>_________________________________________________________________________</div><div>Professional FreeSWITCH Consulting Services:</div><div><a href="mailto:consulting@freeswitch.org">consulting@freeswitch.org</a></div><div><a href="http://www.freeswitchsolutions.com">http://www.freeswitchsolutions.com</a></div><div><br></div><div>FreeSWITCH-powered IP PBX: The CudaTel Communication Server</div><div><a href="http://www.cudatel.com">http://www.cudatel.com</a></div><div><br></div><div>Official FreeSWITCH Sites</div><div><a href="http://www.freeswitch.org">http://www.freeswitch.org</a></div><div><a href="http://wiki.freeswitch.org">http://wiki.freeswitch.org</a></div><div><a href="http://www.cluecon.com">http://www.cluecon.com</a></div><div><br></div><div>FreeSWITCH-dev mailing list</div><div><a href="mailto:FreeSWITCH-dev@lists.freeswitch.org">FreeSWITCH-dev@lists.freeswitch.org</a></div><div><a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev">http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev</a></div><div>UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-dev">http://lists.freeswitch.org/mailman/options/freeswitch-dev</a></div><div><a href="http://www.freeswitch.org">http://www.freeswitch.org</a></div></div></div></span>
</blockquote>
<div>
<br>
</div>