<div>
Hi,
</div><div><br></div><div>I tried to replace the following function which I copied somewhere in msrp.c with <a href="http://docs.freeswitch.org/group__stun1.html#geb124530a232d65edc508afd1b9dd615" style="color: rgb(42, 55, 152); text-decoration: none; font-weight: bold; font-family: Geneva, Arial, Helvetica, sans-serif; font-size: 13px; font-style: normal; font-variant: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; background-color: rgb(250, 250, 250); ">switch_stun_random_string</a> but I found sometimes <a href="http://docs.freeswitch.org/group__stun1.html#geb124530a232d65edc508afd1b9dd615" style="color: rgb(42, 55, 152); text-decoration: none; font-weight: bold; font-family: Geneva, Arial, Helvetica, sans-serif; font-size: 13px; font-style: normal; font-variant: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; background-color: rgb(250, 250, 250); ">switch_stun_random_string</a> returns identical strings on two sequential calls, with the following function I never found, so I still use it.</div><div><br></div><div>By looking the code I understand srand seed is time based so it's possible to return duplicate random string, but I found <a href="http://docs.freeswitch.org/group__stun1.html#geb124530a232d65edc508afd1b9dd615" style="color: rgb(42, 55, 152); text-decoration: none; font-weight: bold; font-family: Geneva, Arial, Helvetica, sans-serif; font-size: 13px; font-style: normal; font-variant: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; background-color: rgb(250, 250, 250); ">switch_stun_random_string</a> used in some places other than stun, just curious would it cause problems?</div><div><br></div><div><div>void random_string(char *buf, switch_size_t size)</div><div>{</div><div><span style="white-space:pre"> </span>long val[4];</div><div><span style="white-space:pre"> </span>int x;</div><div><br></div><div><span style="white-space:pre"> </span>for (x = 0; x < 4; x++)</div><div><span style="white-space:pre"> </span>val[x] = random();</div><div><span style="white-space:pre"> </span>snprintf(buf, size, "%08lx%08lx%08lx%08lx", val[0], val[1], val[2], val[3]);</div><div><span style="white-space:pre"> </span>*(buf+size) = '\0';</div><div>}</div></div>
<div><div><br></div><div>Thanks.</div><div><br></div><div>-- </div><div>About: <a href="http://about.me/dujinfang">http://about.me/dujinfang</a></div><div>Blog: <a href="http://www.dujinfang.com">http://www.dujinfang.com</a></div><div>Proj: <a href="http://www.freeswitch.org.cn">http://www.freeswitch.org.cn</a></div><div><br></div>Sent with <a href="http://www.sparrowmailapp.com">Sparrow</a><br><div><br></div></div>