<div>I made the modifications as you suggested, tested under latest git and committed.</div><div><br></div><div>Yes, I add this field to every event since we already had conference_add_event_data in place.</div><div><br></div>
<div>Thank you.</div><div><br></div><div>Regards,</div>Joćo Mesquita<br>
<br><br><div class="gmail_quote">On Mon, Dec 27, 2010 at 12:45 PM, Anthony Minessale <span dir="ltr"><<a href="mailto:anthony.minessale@gmail.com">anthony.minessale@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
you might want to consider putting the uuid_str in the conference<br>
struct and declare the uuid_t local and just<br>
render it once into the string field. Then you never have to call the<br>
uuid_format again and you probably don't need the binary version for<br>
anything.<br>
<br>
Also do you add this field to every event in the general function that<br>
prepares all conference events for sending?<br>
<br>
<br>
2010/12/26 Joćo Mesquita <<a href="mailto:jmesquita@freeswitch.org">jmesquita@freeswitch.org</a>>:<br>
<div><div></div><div class="h5">> I decided, for now, to take the short way out. That is, use ESL to track the<br>
> events on the conference.<br>
><br>
> One problem that emerged while doing so was how to find unique instances of<br>
> a certain conference. To make it clearer, let me make an example.<br>
><br>
> Conference 123 is created on Sep 20, 2011 and has 20 members.<br>
><br>
> Same conference 123 is created on Sep 21, 2011 but now with 10 members.<br>
><br>
> Besides the obvious time difference, there was a problem identifying that<br>
> the conferences are unique in memory in FreeSWITCH, more accurately, the<br>
> same conference_obj. I came up with the idea then of adding one member to<br>
> the struct. That member is a uuid for that conference and it is added to all<br>
> events spit out by the module, so we know which conference is which<br>
> uniquely.<br>
><br>
> Since this patch adds stuff to the struct, I didn't want to just commit<br>
> without approval, so I would like to kindly ask one of the core devs to take<br>
> a look at it and give me the green light to commit it, if that's the case.<br>
> Sorry for posting it here, but Jira has been out for most of the weekend. I<br>
> will get it in there if it gets back online and this email has not been<br>
> responded yet.<br>
><br>
> The patch is attached.<br>
><br>
> Thank you,<br>
> Joćo Mesquita<br>
><br>
><br>
> 2010/12/25 Joćo Mesquita <<a href="mailto:jmesquita@freeswitch.org">jmesquita@freeswitch.org</a>><br>
>><br>
>> Hello you all. I hope you are all having a good holiday.<br>
>> I have been looking for the best way of tracking conference usage for<br>
>> reporting purposes (basically answering the question: what happened and when<br>
>> on conference nŗ X?) and I thought of the following alternatives that I<br>
>> would like to discuss with you.<br>
>> 1. Using ESL and the CUSTOM events to keep track of what happened when (I<br>
>> guess that's the most widely used)<br>
>> 2. Creating a new entry on switch_caller_profile, that would be filled by<br>
>> the mod_conference module anytime something changes on the conference.<br>
>> Something similar to what the origination_caller_profile does but that would<br>
>> be manipulated by the mod_conference. This option could neatly integrate<br>
>> with the xml cdrs but would mess a little more on the core. Not sure it is<br>
>> desirable.<br>
>> 3. Make mod_conference spit it's own XML for each conference created so<br>
>> that we know what happens and can link offline to other cdr entities.<br>
>> Or, maybe I am completely dumb and trying to do something that it is not<br>
>> supposed to be done or forgetting some resource that is already available.<br>
>><br>
>> Joćo Mesquita<br>
><br>
><br>
</div></div>> _______________________________________________<br>
> FreeSWITCH-dev mailing list<br>
> <a href="mailto:FreeSWITCH-dev@lists.freeswitch.org">FreeSWITCH-dev@lists.freeswitch.org</a><br>
> <a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev</a><br>
> UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-dev</a><br>
> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
><br>
><br>
<br>
<br>
<br>
--<br>
Anthony Minessale II<br>
<br>
FreeSWITCH <a href="http://www.freeswitch.org/" target="_blank">http://www.freeswitch.org/</a><br>
ClueCon <a href="http://www.cluecon.com/" target="_blank">http://www.cluecon.com/</a><br>
Twitter: <a href="http://twitter.com/FreeSWITCH_wire" target="_blank">http://twitter.com/FreeSWITCH_wire</a><br>
<br>
AIM: anthm<br>
<a href="mailto:MSN%3Aanthony_minessale@hotmail.com">MSN:anthony_minessale@hotmail.com</a><br>
GTALK/JABBER/<a href="mailto:PAYPAL%3Aanthony.minessale@gmail.com">PAYPAL:anthony.minessale@gmail.com</a><br>
IRC: <a href="http://irc.freenode.net" target="_blank">irc.freenode.net</a> #freeswitch<br>
<br>
FreeSWITCH Developer Conference<br>
<a href="mailto:sip%3A888@conference.freeswitch.org">sip:888@conference.freeswitch.org</a><br>
<a href="mailto:googletalk%3Aconf%2B888@conference.freeswitch.org">googletalk:conf+888@conference.freeswitch.org</a><br>
pstn:+19193869900<br>
<br>
_______________________________________________<br>
FreeSWITCH-dev mailing list<br>
<a href="mailto:FreeSWITCH-dev@lists.freeswitch.org">FreeSWITCH-dev@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-dev</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
</blockquote></div><br>