<p>Hello,</p>
<p> </p>
<p>Here comes the patch.</p>
<p>The patch fixes the CID for France (and probably other european countries except maybe england where a specific TAS has to be used), both for incoming calls and call waiting cases.</p>
<p>If anybody can try this patch with US hardware to verify the compatibility.</p>
<p>I added a new parameter in openzap.conf (modem-type defaulting to FSK_BELL202) so that modulation can be specified in config.</p>
<p>The patch also adds the MWI functionnality on FXS ports (that meant to also patch mod_voicemail), by using the MWI-Account parameter in directory set to something like "openzap/x/y".</p>
<p> </p>
<p>Please comment on this, if any modification need to be made.</p>
<p> </p>
<p>François</p>
<p> </p>
<p>On Mon, 15 Feb 2010 23:40:38 +0100, <devel@thom.fr.eu.org> wrote:</p>
<blockquote style="border-left: 2px solid #1010ff; padding-left: 5px; margin-left: 5px; width: 100%;"><!-- html ignored --><!-- head ignored --><!-- meta ignored --><!-- meta ignored --><!-- /* Font Definitions */ @font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;} @font-face {font-family:Tahoma; panose-1:2 11 6 4 3 5 4 4 2 4;} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0cm; margin-bottom:.0001pt; font-size:12.0pt; font-family:"Times New Roman","serif";} a:link, span.MsoHyperlink {mso-style-priority:99; color:blue; text-decoration:underline;} a:visited, span.MsoHyperlinkFollowed {mso-style-priority:99; color:purple; text-decoration:underline;} p {mso-style-priority:99; mso-margin-top-alt:auto; margin-right:0cm; mso-margin-bottom-alt:auto; margin-left:0cm; font-size:12.0pt; font-family:"Times New Roman","serif";} span.EmailStyle18 {mso-style-type:personal-reply; font-family:"Calibri","sans-serif"; color:#1F497D;} .MsoChpDefault {mso-style-type:export-only;} @page Section1 {size:612.0pt 792.0pt; margin:70.85pt 70.85pt 70.85pt 70.85pt;} div.Section1 {page:Section1;} -->
<div class="Section1">
<p class="MsoNormal"><span style="font-size: 11.0pt; color: #1F497D;">Hello,<!-- o ignored --></span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; color: #1F497D;"><!-- o ignored --> </span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; color: #1F497D;">I’m very happy to announce I could finally get this to work.<!-- o ignored --></span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; color: #1F497D;"><!-- o ignored --> </span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; color: #1F497D;">So far I only have a very dirty patch so I’ll try to arrange this a little bit, then I’ll post it to the list.<!-- o ignored --></span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; color: #1F497D;"><!-- o ignored --> </span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; color: #1F497D;">Does anybody have an idea on how to make the CID feature configurable (for the different standards used BELL/V23) ?<!-- o ignored --></span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; color: #1F497D;"><!-- o ignored --> </span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; color: #1F497D;">François<!-- o ignored --></span></p>
<p class="MsoNormal"><span style="font-size: 11.0pt; color: #1F497D;"><!-- o ignored --> </span></p>
<div style="border: none; border-top: solid #B5C4DF 1.0pt; padding: 3.0pt 0cm 0cm 0cm;">
<p class="MsoNormal"><strong><span style="font-size: 10.0pt;">De :</span></strong><!-- spanstylefont-size ignored --> freeswitch-dev-bounces@lists.freeswitch.org [mailto:freeswitch-dev-bounces@lists.freeswitch.org] <strong>De la part de</strong> Moises Silva<br /><strong>Envoyé :</strong> mardi 9 février 2010 07:33<br /><strong>À :</strong> freeswitch-dev@lists.freeswitch.org<br /><strong>Objet :</strong> Re: [Freeswitch-dev] Openzap and CLIP<!-- o ignored --></p>
</div>
<p class="MsoNormal"><!-- o ignored --> </p>
<p class="MsoNormal">Hello François,<!-- o ignored --></p>
<div>
<p class="MsoNormal"><!-- o ignored --> </p>
</div>
<div>
<div>
<p class="MsoNormal">On Fri, Feb 5, 2010 at 11:18 AM, François Legal <<!-- ahrefmailto ignored -->devel@thom.fr.eu.org> wrote:<!-- o ignored --></p>
<p>That lead me to think that maybe this is a non implemented feature and maybe the data in fsk_buffer should be sent somewhere to the card.<!-- o ignored --></p>
<p> <!-- o ignored --></p>
<p>Could anybody shed me some light on this.<!-- o ignored --></p>
</div>
<div>
<p class="MsoNormal">I am not terribly familiar with the analog code, but ...<!-- o ignored --></p>
</div>
<div>
<p class="MsoNormal"><!-- o ignored --> </p>
</div>
<div>
<p class="MsoNormal">The fsk buffer seems to be sent when calling send_caller_id(), which is called from ZAP_CHANNEL_STATE_CALLWAITING.<!-- o ignored --></p>
</div>
<div>
<p class="MsoNormal"><!-- o ignored --> </p>
</div>
<div>
<p class="MsoNormal">In any case, there is not much places where the modulated signal can be sent, everything goes down the file descriptor of the channel via zap_channel_write(). As I said, is done through send_caller_id() -> zap_channel_send_fsk_data() which sets the write function pointer to zchan_fsk_write_sample() and is then called back when calling zap_fsk_modulator_send_all().<!-- o ignored --></p>
</div>
<div>
<p class="MsoNormal"><!-- o ignored --> </p>
</div>
<div>
<p class="MsoNormal">May be you should take a look at src/testcid.c to learn about the API usage and src/zap_callerid.c to see the implementation.<!-- o ignored --></p>
</div>
<div>
<p class="MsoNormal"><!-- o ignored --> </p>
</div>
<p class="MsoNormal">-- <br /> Moises Silva<br /> Senior Software Engineer<br /> Sangoma Technologies Inc. | 50 McIntosh Drive, Suite 120, Markham ON L3R 9T3 Canada<br /> t. 1 905 474 1990 x 128 | e. <a href="mailto:moy@sangoma.com">moy@sangoma.com</a><!-- o ignored --></p>
</div>
</div>
</blockquote>
<p> </p>