I like alternate version because it does not limit the scope of the special logging to sessions. It can then be used to aggregate logging on any common filterable item.<br><br><br><div class="gmail_quote">On Mon, Dec 15, 2008 at 8:26 AM, <span dir="ltr"><<a href="mailto:stkn@freeswitch.org">stkn@freeswitch.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi,<br>
<br>
the following series of patches adds a per-session logging capability (patch 1)<br>
and converts a part of mod_sofia over to use the new functions as an example<br>
(patch 2).<br>
<br>
Note: This is one of two possible ways to implement the feature... (see below)<br>
<br>
<br>
Why?:<br>
Some of "us" are running fs with high call volumes and turning on debugging<br>
globally causes massive amounts of space used and reduced performance. This<br>
patch extends the logging api to be able to change the log level for e.g. a<br>
single session (either from the dialplan or via API command / C API)<br>
for diagnosing problems.<br>
<br>
How?:<br>
The core patch adds a couple of new functions:<br>
<br>
switch_core_session_log_printf(switch_core_session_t *, ...)<br>
switch_core_session_set_loglevel()<br>
switch_core_session_get_loglevel()<br>
<br>
A new API command "uuid_loglevel <uuid> <level>" (mod_commands.c)<br>
and a dialplan app "session_loglevel" (mod_dptools.c part of the core patch)<br>
are included.<br>
<br>
The default loglevel of a session is the current global log level.<br>
<br>
All instances of switch_log_printf() that log session-specific messages<br>
need to be converted to the new log function for this to be useful!<br>
(The second patch has the changes for mod_sofia.c)<br>
<br>
<br>
Alternative implementation:<br>
<br>
There's a second way to implement this feature, without adding another<br>
log_printf function:<br>
<br>
switch_log_printf has a "userdata" parameter that is currently unused,<br>
which could be used to pass an additional value (e.g. a session) by<br>
adding additional SWITCH_*_LOG helper macros. A session log call could<br>
look like this:<br>
<br>
switch_log_printf(SWITCH_SESSION_LOG(session), SWITCH_LOG_DEBUG,<br>
"I'm a session debug message\n");<br>
<br>
Pro:<br>
- Can be extended for other type of log actions (e.g. if we want<br>
to implement even more fine-grained logging, per-module etc.)<br>
without adding more switch_*_log_printf functions<br>
<br>
Con:<br>
- More work for switch_log_printf()<br>
<br>
<br>
<br>
Now it's up to you to discuss which way we want to go and if this feature<br>
is deemed useful :P<br>
<br>
Stefan<br>
<br>
<br>
P.S.: The patches are available via http too:<br>
<br>
<a href="http://oss.axsentis.de/people/stkn/freeswitch/fs-r10758-session_loglevel.patch" target="_blank">http://oss.axsentis.de/people/stkn/freeswitch/fs-r10758-session_loglevel.patch</a><br>
<a href="http://oss.axsentis.de/people/stkn/freeswitch/fs-r10758-session_loglevel-convert-mod_sofia.c.patch" target="_blank">http://oss.axsentis.de/people/stkn/freeswitch/fs-r10758-session_loglevel-convert-mod_sofia.c.patch</a><br>
<br>
<br>
Diffstat of the core patch:<br>
<br>
include/private/switch_core_pvt.h | 1<br>
include/switch_core.h | 15 ++++++++++<br>
include/switch_log.h | 18 +++++++++++++<br>
mod/applications/mod_commands/mod_commands.c | 37 +++++++++++++++++++++++++++<br>
mod/applications/mod_dptools/mod_dptools.c | 19 +++++++++++++<br>
switch_core_session.c | 15 ++++++++++<br>
switch_log.c | 34 ++++++++++++++++++++----<br>
7 files changed, 133 insertions(+), 6 deletions(-)<br>
<br>
<br>
--<br>
Stefan Knoblich<br>
Systemadministrator<br>
<br>
axsentis GmbH<br>
Eupener Strasse 74<br>
50933 Köln<br>
<br>
Tel: 0180 - 506 705 521*<br>
Fax: 0180 - 506 705 529*<br>
<br>
E-Mail: <a href="mailto:s.knoblich@axsentis.de">s.knoblich@axsentis.de</a><br>
Web: <a href="http://www.axsentis.de" target="_blank">www.axsentis.de</a><br>
<br>
Eingetragen beim AG Köln: HR B 56238<br>
UST-ID: DE244977565<br>
Gesellschafter-Geschäftsführer:<br>
Yan Lecomte, Eduard Schlein, Apostolos Varsamis<br>
<br>
*14ct/min aus dem Festnetz der T-Com | dtms<br>
<br>
<br>_______________________________________________<br>
Freeswitch-dev mailing list<br>
<a href="mailto:Freeswitch-dev@lists.freeswitch.org">Freeswitch-dev@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-dev</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Anthony Minessale II<br><br>FreeSWITCH <a href="http://www.freeswitch.org/">http://www.freeswitch.org/</a><br>ClueCon <a href="http://www.cluecon.com/">http://www.cluecon.com/</a><br>
<br>AIM: anthm<br><a href="mailto:MSN%3Aanthony_minessale@hotmail.com">MSN:anthony_minessale@hotmail.com</a><br>GTALK/JABBER/<a href="mailto:PAYPAL%3Aanthony.minessale@gmail.com">PAYPAL:anthony.minessale@gmail.com</a><br>
IRC: <a href="http://irc.freenode.net">irc.freenode.net</a> #freeswitch<br><br>FreeSWITCH Developer Conference<br><a href="mailto:sip%3A888@conference.freeswitch.org">sip:888@conference.freeswitch.org</a><br><a href="http://iax:guest@conference.freeswitch.org/888">iax:guest@conference.freeswitch.org/888</a><br>
<a href="mailto:googletalk%3Aconf%2B888@conference.freeswitch.org">googletalk:conf+888@conference.freeswitch.org</a><br>pstn:213-799-1400<br>