<div dir="ltr">try latest trunk r9283<br><br><div class="gmail_quote">2008/8/12 UV <span dir="ltr"><<a href="mailto:uv@talknet.com.au">uv@talknet.com.au</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I agree. That's exactly why I've mentioned that :-)<br>
<div class="Ih2E3d"><br>
-----Original Message-----<br>
From: <a href="mailto:freeswitch-dev-bounces@lists.freeswitch.org">freeswitch-dev-bounces@lists.freeswitch.org</a><br>
</div><div><div></div><div class="Wj3C7c">[mailto:<a href="mailto:freeswitch-dev-bounces@lists.freeswitch.org">freeswitch-dev-bounces@lists.freeswitch.org</a>] On Behalf Of Michael<br>
Collins<br>
Sent: Wednesday, August 13, 2008 3:37 AM<br>
To: <a href="mailto:freeswitch-dev@lists.freeswitch.org">freeswitch-dev@lists.freeswitch.org</a><br>
Subject: Re: [Freeswitch-dev] r9246 - in freeswitch/trunk/src: . include<br>
<br>
If you can convince anthm and MikeJ to turn off "treat warnings as<br>
errors" I'd be surprised. More likely they will want to eliminate the<br>
underlying cause of the warning. If that cannot be eliminated for some<br>
reason then they might consider turning off /WX switch, but I'm sure<br>
that is absolutely the last resort.<br>
<br>
<br>
<br>
-MC<br>
<br>
<br>
<br>
________________________________<br>
<br>
From: <a href="mailto:freeswitch-dev-bounces@lists.freeswitch.org">freeswitch-dev-bounces@lists.freeswitch.org</a><br>
[mailto:<a href="mailto:freeswitch-dev-bounces@lists.freeswitch.org">freeswitch-dev-bounces@lists.freeswitch.org</a>] On Behalf Of UV<br>
Sent: Tuesday, August 12, 2008 10:26 AM<br>
To: <a href="mailto:freeswitch-dev@lists.freeswitch.org">freeswitch-dev@lists.freeswitch.org</a><br>
Subject: Re: [Freeswitch-dev] r9246 - in freeswitch/trunk/src: . include<br>
<br>
<br>
<br>
This change causes FS to not build successfully on Win32:<br>
<br>
error C2220: warning treated as error - no 'object' file generated<br>
switch_ivr_originate.c 424<br>
<br>
warning C4244: '*=': conversion from 'double' to 'switch_size_t',<br>
possible loss of data switch_ivr_originate.c 424<br>
<br>
warning C4244: '*=': conversion from 'double' to 'switch_size_t',<br>
possible loss of data switch_ivr_originate.c 1228<br>
<br>
<br>
<br>
This can be easily resolved by removing the /WX switch (Treat Warning as<br>
Errors) from FreeSwitchCoreLib but I wanted to alert about it before<br>
suggesting it.<br>
<br>
<br>
<br>
… I wonder if posts here actually get anywhere …<br>
<br>
<br>
<br>
-----Original Message-----<br>
From: <a href="mailto:freeswitch-svn-bounces@lists.freeswitch.org">freeswitch-svn-bounces@lists.freeswitch.org</a><br>
[mailto:<a href="mailto:freeswitch-svn-bounces@lists.freeswitch.org">freeswitch-svn-bounces@lists.freeswitch.org</a>] On Behalf Of<br>
Freeswitch SVN<br>
Sent: Tuesday, August 12, 2008 6:41 AM<br>
To: <a href="mailto:freeswitch-svn@lists.freeswitch.org">freeswitch-svn@lists.freeswitch.org</a><br>
Subject: [Freeswitch-svn] [commit] r9246 - in freeswitch/trunk/src: .<br>
include<br>
<br>
<br>
<br>
Author: anthm<br>
<br>
Date: Mon Aug 11 16:41:18 2008<br>
<br>
New Revision: 9246<br>
<br>
<br>
<br>
Modified:<br>
<br>
freeswitch/trunk/src/include/switch_resample.h<br>
<br>
freeswitch/trunk/src/switch_ivr_originate.c<br>
<br>
freeswitch/trunk/src/switch_resample.c<br>
<br>
<br>
<br>
Log:<br>
<br>
fix resampled file in ringback issue from mailing list<br>
<br>
<br>
<br>
Modified: freeswitch/trunk/src/include/switch_resample.h<br>
<br>
========================================================================<br>
======<br>
<br>
--- freeswitch/trunk/src/include/switch_resample.h (original)<br>
<br>
+++ freeswitch/trunk/src/include/switch_resample.h Mon Aug 11<br>
16:41:18 2008<br>
<br>
@@ -60,6 +60,7 @@<br>
<br>
int to_rate;<br>
<br>
/*! the factor to resample by (from / to) */<br>
<br>
double factor;<br>
<br>
+ double rfactor;<br>
<br>
/*! a pointer to store a float buffer for data to be resampled */<br>
<br>
float *from;<br>
<br>
/*! the size of the from buffer used */<br>
<br>
<br>
<br>
Modified: freeswitch/trunk/src/switch_ivr_originate.c<br>
<br>
========================================================================<br>
======<br>
<br>
--- freeswitch/trunk/src/switch_ivr_originate.c (original)<br>
<br>
+++ freeswitch/trunk/src/switch_ivr_originate.c Mon Aug 11 16:41:18 2008<br>
<br>
@@ -420,6 +420,9 @@<br>
<br>
}<br>
<br>
<br>
<br>
olen = mlen;<br>
<br>
+ if (ringback.fh->resampler) {<br>
<br>
+ olen *= ringback.fh->resampler->rfactor;<br>
<br>
+ }<br>
<br>
switch_core_file_read(ringback.fh,<br>
write_frame.data, &olen);<br>
<br>
<br>
<br>
if (olen == 0) {<br>
<br>
@@ -1200,6 +1203,10 @@<br>
<br>
}<br>
<br>
<br>
<br>
olen = mlen;<br>
<br>
+ if (ringback.fh->resampler) {<br>
<br>
+ olen *=<br>
ringback.fh->resampler->rfactor;<br>
<br>
+ }<br>
<br>
+<br>
<br>
<br>
switch_core_file_read(ringback.fh, write_frame.data, &olen);<br>
<br>
<br>
<br>
if (olen == 0) {<br>
<br>
<br>
<br>
Modified: freeswitch/trunk/src/switch_resample.c<br>
<br>
========================================================================<br>
======<br>
<br>
--- freeswitch/trunk/src/switch_resample.c (original)<br>
<br>
+++ freeswitch/trunk/src/switch_resample.c Mon Aug 11 16:41:18 2008<br>
<br>
@@ -72,6 +72,7 @@<br>
<br>
lto_rate = (double) resampler->to_rate;<br>
<br>
lfrom_rate = (double) resampler->from_rate;<br>
<br>
resampler->factor = (lto_rate / lfrom_rate);<br>
<br>
+ resampler->rfactor = (lfrom_rate / lto_rate);<br>
<br>
<br>
<br>
resampler->resampler = resample_open(QUALITY, resampler->factor,<br>
resampler->factor);<br>
<br>
switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_NOTICE, "Activate<br>
Resampler %d->%d %f\n", resampler->from_rate, resampler->to_rate,<br>
<br>
<br>
<br>
<br>
<br>
No virus found in this incoming message.<br>
Checked by AVG - <a href="http://www.avg.com" target="_blank">http://www.avg.com</a><br>
Version: 8.0.138 / Virus Database: 270.6.1/1605 - Release Date:<br>
11/08/2008 16:59<br>
<br>
<br>
<br>
No virus found in this incoming message.<br>
Checked by AVG - <a href="http://www.avg.com" target="_blank">http://www.avg.com</a><br>
</div></div>Version: 8.0.138 / Virus Database: 270.6.1/1607 - Release Date: 12/08/2008<br>
07:19<br>
<br>
No virus found in this outgoing message.<br>
<div class="Ih2E3d">Checked by AVG - <a href="http://www.avg.com" target="_blank">http://www.avg.com</a><br>
</div>Version: 8.0.138 / Virus Database: 270.6.1/1607 - Release Date: 12/08/2008<br>
07:19<br>
<br>
<br>
_______________________________________________<br>
Freeswitch-dev mailing list<br>
<a href="mailto:Freeswitch-dev@lists.freeswitch.org">Freeswitch-dev@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-dev</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
</blockquote></div><br><br clear="all"><br>-- <br>Anthony Minessale II<br><br>FreeSWITCH <a href="http://www.freeswitch.org/">http://www.freeswitch.org/</a><br>ClueCon <a href="http://www.cluecon.com/">http://www.cluecon.com/</a><br>
<br>AIM: anthm<br><a href="mailto:MSN%3Aanthony_minessale@hotmail.com">MSN:anthony_minessale@hotmail.com</a><br>GTALK/JABBER/<a href="mailto:PAYPAL%3Aanthony.minessale@gmail.com">PAYPAL:anthony.minessale@gmail.com</a><br>
IRC: <a href="http://irc.freenode.net">irc.freenode.net</a> #freeswitch<br><br>FreeSWITCH Developer Conference<br><a href="mailto:sip%3A888@conference.freeswitch.org">sip:888@conference.freeswitch.org</a><br><a href="http://iax:guest@conference.freeswitch.org/888">iax:guest@conference.freeswitch.org/888</a><br>
<a href="mailto:googletalk%3Aconf%2B888@conference.freeswitch.org">googletalk:conf+888@conference.freeswitch.org</a><br>pstn:213-799-1400<br>
</div>