[Freeswitch-dev] switch_stun_random_string returns identical strings on two calls randomly

Anthony Minessale anthony.minessale at gmail.com
Tue Jan 31 19:03:42 MSK 2012


ya, you're right.
Fixed in tree....


On Tue, Jan 31, 2012 at 3:51 AM, Seven Du <dujinfang at gmail.com> wrote:
> Hi,
>
> I tried to replace the following function which I copied somewhere in msrp.c
> with  switch_stun_random_string but I found
> sometimes switch_stun_random_string returns identical strings on two
> sequential calls, with the following function I never found, so I still use
> it.
>
> By looking the code I understand srand seed is time based so it's possible
> to return duplicate random string, but I
> found switch_stun_random_string used in some places other than stun, just
> curious would it cause problems?
>
> void random_string(char *buf, switch_size_t size)
> {
> long val[4];
> int x;
>
> for (x = 0; x < 4; x++)
> val[x] = random();
> snprintf(buf, size, "%08lx%08lx%08lx%08lx", val[0], val[1], val[2], val[3]);
> *(buf+size) = '\0';
> }
>
> Thanks.
>
> --
> About: http://about.me/dujinfang
> Blog: http://www.dujinfang.com
> Proj:  http://www.freeswitch.org.cn
>
> Sent with Sparrow
>
>
> _________________________________________________________________________
> Professional FreeSWITCH Consulting Services:
> consulting at freeswitch.org
> http://www.freeswitchsolutions.com
>
> 
> 
>
> Official FreeSWITCH Sites
> http://www.freeswitch.org
> http://wiki.freeswitch.org
> http://www.cluecon.com
>
> FreeSWITCH-dev mailing list
> FreeSWITCH-dev at lists.freeswitch.org
> http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev
> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev
> http://www.freeswitch.org
>



-- 
Anthony Minessale II

FreeSWITCH http://www.freeswitch.org/
ClueCon http://www.cluecon.com/
Twitter: http://twitter.com/FreeSWITCH_wire

AIM: anthm
MSN:anthony_minessale at hotmail.com
GTALK/JABBER/PAYPAL:anthony.minessale at gmail.com
IRC: irc.freenode.net #freeswitch

FreeSWITCH Developer Conference
sip:888 at conference.freeswitch.org
googletalk:conf+888 at conference.freeswitch.org
pstn:+19193869900



Join us at ClueCon 2011 Aug 9-11, 2011
More information about the FreeSWITCH-dev mailing list