[Freeswitch-dev] observations on latest SUBSCRIBE(dialog) behaviour

[Beeton, Carolyn (Carolyn)]

A couple of comments on the "latest" behaviour when I SUBSCRIBE for dialog events on an internal freeswitch application extension:

- No NOTIFY is sent on SUBSCRIBE(dialog) for non-registered endpoints.  The extra three empty fields at the end of line 622 of sofia_presence.c should be removed (presence_id should be the 12th arg, but because of these it is 15th)

- presence is not reported correctly for calls from remote destinations.  The "user" parameter in the resub_callback was recently modified to use the presence_id, but "host" is the from_host (the remote one), which is not correct and results in the START_PRESENCE_SQL not getting any hits.

And a very minor thing, but which causes more queries and messages than is really necessary:

- two PRESENCE_PROBE events are sent when a SUBSCRIBE(dialog) is received.  One is from around line 2335 of sofia_presence.c, the other at the end of the same function (sofia_presence_handle_sip_i_subscribe).  One of them should be removed.

Carolyn
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.freeswitch.org/pipermail/freeswitch-dev/attachments/20101020/76dd17ce/attachment-0001.html