[Freeswitch-dev] [PATCH] Fixed loop unrolling in dialplan configuration

[Travis Cross]

Greetings,

While grepping through the sources to identify how channel variables are
used (and I must say, the FreeSWITCH sources are exquisitely beautiful C
code), I uncovered the following minor issue.  It appears this would have
prevented loop unrolling from working as intended with the in-tree dialplan.

Author: Travis Cross <tc at traviscross.com>
Date:   Fri Oct 17 03:54:12 2008 +0000

    Fixed loop unrolling in dialplan configuration.

    unroll_loops is a preprocessor variable, not a channel variable.

diff --git a/conf/dialplan/default.xml b/conf/dialplan/default.xml
index 61a7500..6bf4ca3 100644
--- a/conf/dialplan/default.xml
+++ b/conf/dialplan/default.xml
@@ -15,7 +15,7 @@
   <context name="default">

     <extension name="unloop">
-      <condition field="${unroll_loops}" expression="^true$"/>
+      <condition field="$${unroll_loops}" expression="^true$"/>
       <condition field="${sip_looped_call}" expression="^true$">
 	<action application="deflect" data="${destination_number}"/>
       </condition>
diff --git a/conf/dialplan/public.xml b/conf/dialplan/public.xml
index 49b8850..5c8cdc5 100644
--- a/conf/dialplan/public.xml
+++ b/conf/dialplan/public.xml
@@ -14,7 +14,7 @@
   <context name="public">

     <extension name="unloop">
-      <condition field="${unroll_loops}" expression="^true$"/>
+      <condition field="$${unroll_loops}" expression="^true$"/>
       <condition field="${sip_looped_call}" expression="^true$">
 	<action application="deflect" data="${destination_number}"/>
       </condition>



Cheers,

-- Travis